You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/11/04 05:50:43 UTC
[jclouds-labs-google] Fix some obvious bugs in google-cloud-storage.
(#76)
More work to do, as still many live tests fail.
google cloud storage is not in as good shape as google compute engine. Needs more non-live tests, particularly parse tests.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-google adrian.google-cloud-storage-bugs
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/76
-- Commit Summary --
* JCLOUDS-458 Fix some obvious bugs in google-cloud-storage.
-- File Changes --
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/binders/MultipartUploadBinder.java (19)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GCSBlobStore.java (28)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (21)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/GCSObject.java (22)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectApi.java (3)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/76.patch
https://github.com/jclouds/jclouds-labs-google/pull/76.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
picked into master
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61667449
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
> @@ -105,9 +104,10 @@ protected GCSBlobStore(BlobStoreContext context, BlobUtils blobUtils, Supplier<L
>
> @Override
> public PageSet<? extends StorageMetadata> list() {
> - return new Function<ListPage<Bucket>, org.jclouds.blobstore.domain.PageSet<? extends StorageMetadata>>() {
> - public org.jclouds.blobstore.domain.PageSet<? extends StorageMetadata> apply(ListPage<Bucket> from) {
> - return new PageSetImpl<StorageMetadata>(Iterables.transform(from, bucketToStorageMetadata), null);
> + return new Function<ListPage<Bucket>, PageSet<? extends StorageMetadata>>() {
> + public PageSet<? extends StorageMetadata> apply(ListPage<Bucket> from) {
> + return new PageSetImpl<StorageMetadata>(Iterables.transform(from, bucketToStorageMetadata),
> + from.nextPageToken());
oops.. of course many folks won't have that many buckets.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76/files#r19785765
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
After this change, live tests are better, but still not great.
```
Failed tests:
GCSBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:271 null
BucketAccessControlsApiLiveTest.testCreateBucketAcl:49->createBucket:43 » HttpResponse
BucketApiLiveTest.testCreateBucket:69 » HttpResponse command: POST https://www...
BucketApiLiveTest.testCreateBucketWithOptions:119 » HttpResponse command: POST...
DefaultObjectAccessControlsApiLiveTest.testCreateDefaultObjectAcl:49->createBucket:43 » HttpResponse
ObjectApiLiveTest.createBucket:93 » HttpResponse command: POST https://www.goo...
Tests run: 102, Failures: 6, Errors: 0, Skipped: 54
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61593367
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #213](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/213/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61593792
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1615](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1615/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61593586
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1616](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1616/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61593935
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
> @@ -483,6 +482,6 @@ GCSObject copyObject(@PathParam("destinationBucket") String destinationBucket,
> @OAuthScopes(STORAGE_FULLCONTROL_SCOPE)
> @MapBinder(MultipartUploadBinder.class)
> GCSObject multipartUpload(@PathParam("bucket") String bucketName,
> - @BinderParam(BindToJsonPayload.class) ObjectTemplate objectTemplate,
> + @PayloadParam("template") ObjectTemplate objectTemplate,
oops
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76/files#r19785774
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
> @Override public <R extends HttpRequest> R bindToRequest(R request, Map<String, Object> postParams) {
> ObjectTemplate template = (ObjectTemplate) postParams.get("template");
> Payload payload = (Payload) postParams.get("payload");
>
> - String contentType = checkNotNull(template.cacheControl(), "contentType");
> + String contentType = checkNotNull(template.contentType(), "contentType");
oops
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76/files#r19785771
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1617](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1617/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61594205
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #211](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/211/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61593428
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
> @@ -44,31 +44,31 @@
> public abstract String etag();
> public abstract String name();
> public abstract String bucket();
> - public abstract Long generation();
> - public abstract Long metageneration();
> + public abstract long generation();
ps this is sooo much nicer than having to muck with checkNotNull, then also adjust Nullable annotation, right?! cc @jdaggett
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76/files#r19785808
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1618](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1618/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61594519
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
Closed #76.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#event-188122984
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #214](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/214/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61594153
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by Adrian Cole <no...@github.com>.
> @@ -44,31 +44,31 @@
> public abstract String etag();
> public abstract String name();
> public abstract String bucket();
> - public abstract Long generation();
> - public abstract Long metageneration();
> + public abstract long generation();
lots of oops here :P
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76/files#r19785781
Re: [jclouds-labs-google] Fix some obvious bugs in
google-cloud-storage. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #212](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/212/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61593758