You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2016/08/22 23:22:05 UTC
[Impala-ASF-CR] IMPALA-3986: Python hive-client may fail silently while dropping partitions
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4083
Change subject: IMPALA-3986: Python hive-client may fail silently while dropping partitions
......................................................................
IMPALA-3986: Python hive-client may fail silently while dropping partitions
It was noticed during a test run that a partition existed in the HMS
when it shouldn't have. The only possible explanation for that is that
the python based hive client failed to drop the partition when asked
to and we did not check for an error when it did so.
This patch just adds an assert to make sure that the partition is
dropped when instructed to, else it will cause the test to fail in
the right place.
Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
---
M tests/common/impala_test_suite.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/4083/1
--
To view, visit http://gerrit.cloudera.org:8080/4083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-3986: Python hive-client may fail silently while dropping partitions
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3986: Python hive-client may fail silently while dropping partitions
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3986: Python hive-client may fail silently while dropping partitions
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4083
to look at the new patch set (#2).
Change subject: IMPALA-3986: Python hive-client may fail silently while dropping partitions
......................................................................
IMPALA-3986: Python hive-client may fail silently while dropping partitions
It was noticed during a test run that a partition existed in the HMS
when it shouldn't have. The only possible explanation for that is that
the python based hive client failed to drop the partition when asked
to and we did not check for an error when it did so.
This patch just adds an assert to make sure that the partition is
dropped when instructed to, else it will cause the test to fail in
the right place.
Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
---
M tests/common/impala_test_suite.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/4083/2
--
To view, visit http://gerrit.cloudera.org:8080/4083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-3986: Python hive-client may fail silently while dropping partitions
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-3986: Python hive-client may fail silently while dropping partitions
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4083/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
PS1, Line 494: , 'Could
> If the fn returns True you should be able to drop this check
Done
--
To view, visit http://gerrit.cloudera.org:8080/4083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3986: Python hive-client may fail silently while dropping partitions
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3986: Python hive-client may fail silently while dropping partitions
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4083/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
PS1, Line 494: == True
If the fn returns True you should be able to drop this check
--
To view, visit http://gerrit.cloudera.org:8080/4083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3986: Python hive-client may fail silently while dropping partitions
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3986: Python hive-client may fail silently while dropping partitions
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3986: Python hive-client may fail silently while dropping partitions
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3986: Python hive-client may fail silently while dropping partitions
......................................................................
IMPALA-3986: Python hive-client may fail silently while dropping partitions
It was noticed during a test run that a partition existed in the HMS
when it shouldn't have. The only possible explanation for that is that
the python based hive client failed to drop the partition when asked
to and we did not check for an error when it did so.
This patch just adds an assert to make sure that the partition is
dropped when instructed to, else it will cause the test to fail in
the right place.
Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Reviewed-on: http://gerrit.cloudera.org:8080/4083
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Internal Jenkins
---
M tests/common/impala_test_suite.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Matthew Jacobs: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4241225d19c75a79179a61fef0c75c06a9a2ac39
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>