[GitHub] [cassandra] mike-tr-adamson commented on a diff in pull request #2409: Numeric on-disk index write and search

["mike-tr-adamson (via GitHub)" <gi...@apache.org>]

mike-tr-adamson commented on code in PR #2409:
URL: https://github.com/apache/cassandra/pull/2409#discussion_r1227896800


##########
src/java/org/apache/cassandra/index/sai/utils/TypeUtil.java:
##########
@@ -130,6 +131,23 @@ public static ByteComparable max(ByteComparable a, ByteComparable b)
         return a == null ? b : (b == null || ByteComparable.compare(b, a, ByteComparable.Version.OSS50) < 0) ? a : b;
     }
 
+    /**
+     * Returns the value length for the given {@link AbstractType}, selecting 16 for types
+     * that officially use VARIABLE_LENGTH but are, in fact, of a fixed length.
+     */
+    public static int fixedSizeOf(AbstractType<?> type)

Review Comment:
   We had this discussion previously and I said that I would look at adding this change to this PR. I did spend some time looking at this and came to the conclusion that this needed a separate ticket (as you noted). If have raised [CASSANDRA-18590](https://issues.apache.org/jira/browse/CASSANDRA-18590) for this as part of phase 2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org