You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/04/19 09:19:06 UTC
[GitHub] [dolphinscheduler] lyyprean commented on a change in pull request #5156: [Improvement-5147][Service]This judgment always returns true
lyyprean commented on a change in pull request #5156:
URL: https://github.com/apache/dolphinscheduler/pull/5156#discussion_r615681482
##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -711,6 +700,14 @@ private ProcessInstance constructProcessInstance(Command command, String host) {
if (commandTypeIfComplement == CommandType.REPEAT_RUNNING) {
setGlobalParamIfCommanded(processDefinition, cmdParam);
}
+
+ // Recalculate global parameters after rerun.
+
+ processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
+ processDefinition.getGlobalParamMap(),
+ processDefinition.getGlobalParamList(),
+ commandTypeIfComplement,
+ processInstance.getScheduleTime()));
Review comment:
It is useless, has been deleted, thanks for correcting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org