[jira] [Commented] (HBASE-25673) Wrong log regarding current active master at ZKLeaderManager#waitToBecomeLeader

["Anoop Sam John (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304236#comment-17304236 ] 

Anoop Sam John commented on HBASE-25673:
----------------------------------------

Thanks for the reviews. Pushed to branch-2 and master.

> Wrong log regarding current active master at ZKLeaderManager#waitToBecomeLeader
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-25673
>                 URL: https://issues.apache.org/jira/browse/HBASE-25673
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> {code}
> byte[] currentId = ZKUtil.getDataAndWatch(watcher, leaderZNode);
> if (currentId != null && Bytes.equals(currentId, nodeId)) {
>   ....
> } else {
>   LOG.info("Found existing leader with ID: {}", Bytes.toStringBinary(nodeId));
>   leaderExists.set(true);
> }
> {code}
> Existing id, read from ZK, is currentId. But by mistake we log 'nodeId' which is the this master's node id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)