You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by WeichenXu123 <gi...@git.apache.org> on 2016/08/29 15:16:00 UTC

[GitHub] zeppelin pull request #1382: [ZEPPELIN-1391][Interpreters] print error while...

GitHub user WeichenXu123 opened a pull request:

    https://github.com/apache/zeppelin/pull/1382

    [ZEPPELIN-1391][Interpreters] print error while existing registedInterpreter with the same key but different settings

    ### What is this PR for?
    print error while existing registedInterpreter with the same key but different settings.
    In order to compare the property Map in the Interpreter easily,
    I override the `equals` method in `InterpreterProperty` class. (and `hashCode` at the same time)
    
    and I fix a small error in  `InterpreterProperty.toString()`, its result forgot `}` in the end. 
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1391
    
    ### How should this be tested?
    Existing tests.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WeichenXu123/zeppelin interpreter_key_error_check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1382
    
----
commit ccfe8e03ec5566fae543748d968a08cdf1d0fee7
Author: WeichenXu <we...@outlook.com>
Date:   2016-08-28T07:10:50Z

    print error while existing registedInterpreter with the same key but different settings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1382: [ZEPPELIN-1391][Interpreters] print error while existi...

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1382
  
    LGTM. Merging if there's no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1382: [ZEPPELIN-1391][Interpreters] print error while...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1382


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1382: [ZEPPELIN-1391][Interpreters] print error while existi...

Posted by WeichenXu123 <gi...@git.apache.org>.

Github user WeichenXu123 commented on the issue:

    https://github.com/apache/zeppelin/pull/1382
  
    cc @jongyoul thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---