You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2025/02/23 03:55:06 UTC
Re: [PR] [SPARK-51293][CORE][SQL][SS][MLLIB][TESTS] Cleanup unused private functions from test suites [spark]
dongjoon-hyun commented on code in PR #50049:
URL: https://github.com/apache/spark/pull/50049#discussion_r1966664038
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/logical/DistinctKeyVisitorSuite.scala:
##########
@@ -47,9 +45,6 @@ class DistinctKeyVisitorSuite extends PlanTest {
assert(plan.analyze.distinctKeys === distinctKeys)
}
- implicit private def productEncoder[T <: Product : TypeTag]: ExpressionEncoder[T] =
Review Comment:
Oh, is this really unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org