You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/02/04 13:55:02 UTC
Review Request 56307: HiveView2.0 : Upload CSV, JSON,
XML to create table feature is missing in the new view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56307/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Bugs: AMBARI-19872
https://issues.apache.org/jira/browse/AMBARI-19872
Repository: ambari
Description
-------
added the feature to upload file and create a table
Diffs
-----
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 44c82a0
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java PRE-CREATION
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java 71cedd1
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/CSVParams.java 355ed6a
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableDataReader.java ee148b8
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableInput.java 4f15c57
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadFromHdfsInput.java c755c02
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java 835626d
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/Parser.java a012463
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/PreviewData.java 50af529
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java 027baff
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/QueryGenerator.java dda178d
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/RowFormat.java 4c1cb2b
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/TableInfo.java bb39271
contrib/views/hive20/src/main/resources/ui/app/adapters/file-uploader.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/components/simple-table.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/components/upload-table-source.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/configs/helpers.js 025caa6
contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/models/column.js b1fa99c
contrib/views/hive20/src/main/resources/ui/app/router.js bc9bfa5
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js 6dfdf29
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 453eb12
contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 264e617
contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/components/radio-button.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/components/simple-table.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table-source.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/components/validated-text-field.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs 39b7a9e
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/utils/constants.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7
contrib/views/hive20/src/main/resources/ui/config/environment.js 9efd491
contrib/views/hive20/src/main/resources/ui/package.json ed7a299
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserCSVTest.java 8006e91
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserJSONTest.java a15e5d4
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserXMLTest.java 07e7c7c
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/QueryGeneratorTest.java 1a0d34a
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/TableDataReaderTest.java 340a921
Diff: https://reviews.apache.org/r/56307/diff/
Testing
-------
updated test cases and manual testing
Thanks,
Nitiraj Rathore
Re: Review Request 56307: HiveView2.0 : Upload CSV, JSON,
XML to create table feature is missing in the new view
Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56307/#review164343
-----------------------------------------------------------
Ship it!
Ship It!
- Rohit Choudhary
On Feb. 4, 2017, 1:54 p.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56307/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2017, 1:54 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-19872
> https://issues.apache.org/jira/browse/AMBARI-19872
>
>
> Repository: ambari
>
>
> Description
> -------
>
> added the feature to upload file and create a table
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 44c82a0
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java PRE-CREATION
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java 71cedd1
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/CSVParams.java 355ed6a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableDataReader.java ee148b8
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableInput.java 4f15c57
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadFromHdfsInput.java c755c02
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java 835626d
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/Parser.java a012463
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/PreviewData.java 50af529
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java 027baff
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/QueryGenerator.java dda178d
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/RowFormat.java 4c1cb2b
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/TableInfo.java bb39271
> contrib/views/hive20/src/main/resources/ui/app/adapters/file-uploader.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/simple-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table-source.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/configs/helpers.js 025caa6
> contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/models/column.js b1fa99c
> contrib/views/hive20/src/main/resources/ui/app/router.js bc9bfa5
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js 6dfdf29
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 453eb12
> contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 264e617
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/radio-button.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/simple-table.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table-source.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/validated-text-field.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs 39b7a9e
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/utils/constants.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7
> contrib/views/hive20/src/main/resources/ui/config/environment.js 9efd491
> contrib/views/hive20/src/main/resources/ui/package.json ed7a299
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserCSVTest.java 8006e91
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserJSONTest.java a15e5d4
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserXMLTest.java 07e7c7c
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/QueryGeneratorTest.java 1a0d34a
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/TableDataReaderTest.java 340a921
>
> Diff: https://reviews.apache.org/r/56307/diff/
>
>
> Testing
> -------
>
> updated test cases and manual testing
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 56307: HiveView2.0 : Upload CSV, JSON,
XML to create table feature is missing in the new view
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56307/#review164465
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 4, 2017, 1:54 p.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56307/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2017, 1:54 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-19872
> https://issues.apache.org/jira/browse/AMBARI-19872
>
>
> Repository: ambari
>
>
> Description
> -------
>
> added the feature to upload file and create a table
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 44c82a0
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java PRE-CREATION
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java 71cedd1
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/CSVParams.java 355ed6a
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableDataReader.java ee148b8
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableInput.java 4f15c57
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadFromHdfsInput.java c755c02
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java 835626d
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/Parser.java a012463
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/PreviewData.java 50af529
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java 027baff
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/QueryGenerator.java dda178d
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/RowFormat.java 4c1cb2b
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/TableInfo.java bb39271
> contrib/views/hive20/src/main/resources/ui/app/adapters/file-uploader.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/simple-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table-source.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/configs/helpers.js 025caa6
> contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/models/column.js b1fa99c
> contrib/views/hive20/src/main/resources/ui/app/router.js bc9bfa5
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js 6dfdf29
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 453eb12
> contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js 264e617
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/radio-button.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/simple-table.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table-source.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/components/validated-text-field.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs 39b7a9e
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/utils/constants.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7
> contrib/views/hive20/src/main/resources/ui/config/environment.js 9efd491
> contrib/views/hive20/src/main/resources/ui/package.json ed7a299
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserCSVTest.java 8006e91
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserJSONTest.java a15e5d4
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/DataParserXMLTest.java 07e7c7c
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/QueryGeneratorTest.java 1a0d34a
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/resources/upload/TableDataReaderTest.java 340a921
>
> Diff: https://reviews.apache.org/r/56307/diff/
>
>
> Testing
> -------
>
> updated test cases and manual testing
>
>
> Thanks,
>
> Nitiraj Rathore
>
>