You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "egalpin (via GitHub)" <gi...@apache.org> on 2023/06/08 23:58:38 UTC
[GitHub] [pinot] egalpin opened a new issue, #10875: Adding new column as noDictionaryColumn to existing table causes query-time exceptions
egalpin opened a new issue, #10875:
URL: https://github.com/apache/pinot/issues/10875
https://github.com/apache/pinot/issues/10713 seems highly related to an issue I've found recently, where adding a new STRING column to an existing schema (existing table) while also adding it to noDictionaryColumns, then executing a segment reload, results in errors at query time.
The errors emanate from the fact that the segment reload process for sealed segments exclusively sets the new column values to a singular (default) value; in doing so, the cardinality of the column is 1. When the cardinality of the column is 1, the column is inferred to be sorted.
Because the segment metadata indicates that the column is sorted, the column's value reader is instantiated as an instance of `SortedIndexReaderImpl`, which exclusively works with dictionary encoding.
Could a similar fix be applied as in https://github.com/apache/pinot/pull/10851 to also address this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #10875: Adding new column as noDictionaryColumn to existing table causes query-time exceptions
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #10875: Adding new column as noDictionaryColumn to existing table causes query-time exceptions
URL: https://github.com/apache/pinot/issues/10875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] gortiz commented on issue #10875: Adding new column as noDictionaryColumn to existing table causes query-time exceptions
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on issue #10875:
URL: https://github.com/apache/pinot/issues/10875#issuecomment-1586866640
It should fix that. @egalpin confirmed that in https://github.com/apache/pinot/issues/10713#issuecomment-1585154450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10875: Adding new column as noDictionaryColumn to existing table causes query-time exceptions
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10875:
URL: https://github.com/apache/pinot/issues/10875#issuecomment-1584064723
cc @gortiz Can you confirm if #10851 can also solve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10875: Adding new column as noDictionaryColumn to existing table causes query-time exceptions
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10875:
URL: https://github.com/apache/pinot/issues/10875#issuecomment-1595150238
Verified that #10851 fixed the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org