You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/12/05 22:16:49 UTC
Review Request 54391: Added ability for client to signal EOF on
ATTACH_CONTAINER_INPUT.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54391/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Jie Yu.
Repository: mesos
Description
-------
Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.cpp 4258e861357225d7f9613b66f66121e28961dbf1
Diff: https://reviews.apache.org/r/54391/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
No new unit tests added for this, but tested manually with the CLI and it works as expected.
Thanks,
Kevin Klues
Re: Review Request 54391: Added ability for client to signal EOF on
ATTACH_CONTAINER_INPUT.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54391/#review158118
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54391]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 5, 2016, 10:18 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54391/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 10:18 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Jie Yu.
>
>
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp 4258e861357225d7f9613b66f66121e28961dbf1
>
> Diff: https://reviews.apache.org/r/54391/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
>
> No new unit tests added for this, but tested manually with the CLI and it works as expected.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 54391: Added ability for client to signal EOF on
ATTACH_CONTAINER_INPUT.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54391/#review158248
-----------------------------------------------------------
Ship it!
LGTM.
- Jie Yu
On Dec. 5, 2016, 10:18 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54391/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 10:18 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Jie Yu.
>
>
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp 4258e861357225d7f9613b66f66121e28961dbf1
>
> Diff: https://reviews.apache.org/r/54391/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
>
> No new unit tests added for this, but tested manually with the CLI and it works as expected.
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 54391: Added ability for client to signal EOF on
ATTACH_CONTAINER_INPUT.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54391/
-----------------------------------------------------------
(Updated Dec. 5, 2016, 10:18 p.m.)
Review request for mesos, Anand Mazumdar and Jie Yu.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.cpp 4258e861357225d7f9613b66f66121e28961dbf1
Diff: https://reviews.apache.org/r/54391/diff/
Testing
-------
GTEST_FILTER="" make -j check
sudo src/mesos-tests
No new unit tests added for this, but tested manually with the CLI and it works as expected.
Thanks,
Kevin Klues