You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Chetan Mehrotra (JIRA)" <ji...@apache.org> on 2016/11/25 05:05:58 UTC

[jira] [Commented] (OAK-5121) review CommitInfo==null in BackgroundObserver with isExternal change

    [ https://issues.apache.org/jira/browse/OAK-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694852#comment-15694852 ] 

Chetan Mehrotra commented on OAK-5121:
--------------------------------------

For OAK-4898 I have change the BackgroundObserver to use CommitInfo.EMPTY_EXTERNAL for commit info when doing compaction of content change. So that part is ok. Pending work there now is to merge ChangeSet when doing such compaction but that is more of optimization

[~egli] Is that understanding correct?

> review CommitInfo==null in BackgroundObserver with isExternal change
> --------------------------------------------------------------------
>
>                 Key: OAK-5121
>                 URL: https://issues.apache.org/jira/browse/OAK-5121
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core
>    Affects Versions: 1.5.13
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>             Fix For: 1.6
>
>
> OAK-4898 changes CommitInfo to be never null. This is the case outside of the BackgroundObserver - but in the BackgroundObserver itself it is explicitly set to null when compacting. 
> Once OAK-4898 is committed this task is about reviewing the implications in BackgroundObserver wrt compaction and CommitInfo==null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)