You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/12/20 19:35:00 UTC

[jira] [Commented] (CALCITE-3809) RexSimplify simplifies nondeterministic function incorrectly

    [ https://issues.apache.org/jira/browse/CALCITE-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252498#comment-17252498 ] 

Julian Hyde commented on CALCITE-3809:
--------------------------------------

There was a really unhelpful change in this commit. Previously {{RexInterpreter}} had a list of expressions that it *cannot* handle (which just included CAST); after this change, it has a list of expressions that it *can* handle (which excludes important ones such as {{IS_NOT_NULL}}). As a result, we have lost a lot of test coverage.

> RexSimplify simplifies nondeterministic function incorrectly
> ------------------------------------------------------------
>
>                 Key: CALCITE-3809
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3809
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Chunwei Lei
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.23.0
>
>          Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> For example, {{rand() = rand()}} will be simplified to {{IS NOT NULL(rand())}}, which is wrong because {{rand() = rand()}} might be false while {{IS NOT NULL(rand())}} is always true.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)