[jira] [Commented] (RATIS-683) Test and cleanup Ratis Metrics.

["Aravindan Vijayan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953036#comment-16953036 ] 

Aravindan Vijayan commented on RATIS-683:
-----------------------------------------

[~shashikant] | [~msingh] | [~swagle] I will take this up when all the other tasks in RATIS-646 are done. This will be a good stopping point to clean up some code before adding more metrics in the future. Please let me know if there are any other suggestions. 

> Test and cleanup Ratis Metrics.
> -------------------------------
>
>                 Key: RATIS-683
>                 URL: https://issues.apache.org/jira/browse/RATIS-683
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Lokesh Jain
>            Assignee: Aravindan Vijayan
>            Priority: Major
>
> Since the Ratis metrics work is going on in parallel from multiple folks, it will be a good idea to have a final sanity check and cleanup tasks to bring the Task to closure. These are the tasks aimed in this JIRA. 
> * Organize RatisMetrics and RatisMetricNames into a single class
> (It would be good to organize RatisMetrics and RatisMetricNames into a single class. The metrics can be organized like RaftServerConfigKeys and RaftClientConfigKeys so that metrics corresponding to a particular component like Log, Appender can be tracked in a sub class)
> * Investigate whether we can move the groupId and followerId in metric names to attributes. This will make aggregation from a metrics system easier.
> * Deploy a cluster and do sanity check of all metrics. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)