[jira] [Comment Edited] (FLINK-15220) Add startFromTimestamp in KafkaTableSource

["Jark Wu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994517#comment-16994517 ] 

Jark Wu edited comment on FLINK-15220 at 12/12/19 10:46 AM:
------------------------------------------------------------

+1 to do this. Before starting the work, could you please share the basic design for the APIs? Because currenlty, we support descritor API, YAML, DDL at the same time [1]. My initial thought is as following (not though throughly):

{code:java}
// descriptor API
new Kafka()
  .startFromTimestamp(LocalDateTime)
  // or
  .startFromTimestamp(long millisFromEpoch)

// DDL
'connector.startup-mode' = 'timestamp',
'connector.startup-timestamp' = '2019-12-12 10:11:23.123'
{code}



[1]: https://ci.apache.org/projects/flink/flink-docs-master/dev/table/connect.html#kafka-connector


was (Author: jark):
+1 to do this. Before starting the work, could you please share the basic design for the APIs? Because currenlty, we support descritor API, YAML, DDL at the same time [1]. My initial though is as following (not though throughly):

{code:java}
// descriptor API
new Kafka()
  .startFromTimestamp(LocalDateTime)
  // or
  .startFromTimestamp(long millisFromEpoch)

// DDL
'connector.startup-mode' = 'timestamp',
'connector.startup-timestamp' = '2019-12-12 10:11:23.123'
{code}



[1]: https://ci.apache.org/projects/flink/flink-docs-master/dev/table/connect.html#kafka-connector

> Add startFromTimestamp in KafkaTableSource
> ------------------------------------------
>
>                 Key: FLINK-15220
>                 URL: https://issues.apache.org/jira/browse/FLINK-15220
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kafka
>    Affects Versions: 1.10.0
>            Reporter: Paul Lin
>            Priority: Major
>
> KafkaTableSource supports all startup modes in DataStream API except `startFromTimestamp`, but `startFromTimestamp` is a common and valid use case in Table/SQL API as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)