You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Glauche (JIRA)" <ji...@codehaus.org> on 2011/02/20 22:45:24 UTC
[jira] Issue Comment Edited: (MWAR-248) Plugin warns about missing
webxml attribute even if one exists
[ http://jira.codehaus.org/browse/MWAR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256971#action_256971 ]
Michael Glauche edited comment on MWAR-248 at 2/20/11 3:45 PM:
---------------------------------------------------------------
something like this is needed in the WarArchiver (needs some cleanup):
Index: src/main/java/org/codehaus/plexus/archiver/war/WarArchiver.java
===================================================================
--- src/main/java/org/codehaus/plexus/archiver/war/WarArchiver.java (revision 8799)
+++ src/main/java/org/codehaus/plexus/archiver/war/WarArchiver.java (working copy)
@@ -167,10 +167,13 @@
&& ( deploymentDescriptor == null
|| !ResourceUtils.isCanonicalizedSame( entry.getResource(), deploymentDescriptor ) ) ) )
{
- getLogger().warn( "Warning: selected " + archiveType
+ if ( deploymentDescriptor == null
+ || !ResourceUtils.isCanonicalizedSame( entry.getResource(), deploymentDescriptor ) ) {
+ getLogger().warn( "Warning: selected " + archiveType
+ " files include a WEB-INF/web.xml which will be ignored "
+ "\n(webxml attribute is missing from "
+ archiveType + " task, or ignoreWebxml attribute is specified as 'true')" );
+ }
}
else
{
was (Author: mglauche):
something like this is needed in the WarArchiver (needs some cleanup):
Index: src/main/java/org/codehaus/plexus/archiver/war/WarArchiver.java
===================================================================
--- src/main/java/org/codehaus/plexus/archiver/war/WarArchiver.java (revision 8799)
+++ src/main/java/org/codehaus/plexus/archiver/war/WarArchiver.java (working copy)
@@ -167,10 +167,13 @@
&& ( deploymentDescriptor == null
|| !ResourceUtils.isCanonicalizedSame( entry.getResource(), deploymentDescriptor ) ) ) )
{
- getLogger().warn( "Warning: selected " + archiveType
+ if ( deploymentDescriptor == null
+ || !ResourceUtils.isCanonicalizedSame( entry.getResource(), deploymentDescriptor ) ) {
+ getLogger().warn( "Warning: selected " + archiveType
+ " files include a WEB-INF/web.xml which will be ignored "
+ "\n(webxml attribute is missing from "
+ archiveType + " task, or ignoreWebxml attribute is specified as 'true')" );
+ }
}
else
{
> Plugin warns about missing webxml attribute even if one exists
> --------------------------------------------------------------
>
> Key: MWAR-248
> URL: http://jira.codehaus.org/browse/MWAR-248
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1.1
> Reporter: Gili
> Attachments: debug.log
>
>
> I am attaching a debug log that clearly demonstrates how the WAR plugin warns about a missing webxml attribute which exists. I am attempting to let the plugin know that the web.xml file it is encountering is the same one specified by the webxml attribute.
> My pom file contains:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-war-plugin</artifactId>
> <version>2.1.1</version>
> <configuration>
> <failOnMissingWebXml>true</failOnMissingWebXml>
> <webXml>src/main/webapp/WEB-INF/web.xml</webXml>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira