You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2004/07/11 00:41:39 UTC

[apreq-2] glue/perl/t/apreq/cgi tests

I'm still having trouble printing to the error log the large
strings involved in some of the tests in
glue/perl/t/apreq/cgi.t on Win32 - when it gets up to
lengths of about 10000, it just hangs. Would the following
patch be OK:
============================================================
Index: glue/perl/t/apreq/cgi.t
===================================================================
RCS file: /home/cvs/httpd-apreq-2/glue/perl/t/apreq/cgi.t,v
retrieving revision 1.3
diff -u -r1.3 cgi.t
--- glue/perl/t/apreq/cgi.t	8 Jul 2004 02:10:05 -0000	1.3
+++ glue/perl/t/apreq/cgi.t	10 Jul 2004 22:15:41 -0000
@@ -202,8 +202,9 @@
     for ($req->param) {
         my $param = $req->param($_);
         next unless $param;
-        apreq_log("$_ => $param");
-        $len += length($_) + length($param);
+        my $length = length($param);
+        apreq_log("$_ has a value of length $length");
+        $len += length($_) + $length;
     }
     print $len;
 }

================================================================
together with a note in the STATUS to look later at this
issue?

-- 
best regards,
randy

Re: [apreq-2] glue/perl/t/apreq/cgi tests

Posted by Joe Schaefer <jo...@sunstarsys.com>.
Randy Kobes <ra...@theoryx5.uwinnipeg.ca> writes:

> I'm still having trouble printing to the error log the large
> strings involved in some of the tests in
> glue/perl/t/apreq/cgi.t on Win32 - when it gets up to
> lengths of about 10000, it just hangs. 

Right- I bet its the same problem (the stderr buffer is 
full, so stdio tries to flush it but the server doesn't 
notice the event).

+1 on all patches, and feel free fix the arg ordering
in the tests.

Thanks!
-- 
Joe Schaefer