[GitHub] [solr] epugh commented on a diff in pull request #1037: enable more errorprone rules and fix those things that fail

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1037:
URL: https://github.com/apache/solr/pull/1037#discussion_r977492822


##########
solr/core/src/test/org/apache/solr/cloud/TestStressInPlaceUpdates.java:
##########
@@ -485,7 +485,7 @@ public void run() {
                   } else {
                     fail(
                         String.format(
-                            Locale.ENGLISH, "There were more than one result: {}", response));

Review Comment:
   I always liked the `{}`, but that my be the rubyist in me, where string interpolation is `"String #{mystring}"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org