You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/12/23 15:06:47 UTC
[GitHub] [activemq-artemis] andytaylor opened a new pull request #3389: ARTEMIS-3043 - improvements on new console
andytaylor opened a new pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389
https://issues.apache.org/jira/browse/ARTEMIS-3043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-750614327
Can we add back ability to change column widths?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-751719165
updated PR after feedback. fyi some of the table columns weren't even exposed in the server side views, in the new year I'm going to add some tests to catch these being missed when attributes are added to queues etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756656704
Column resizing might not even be possible, Im investigating now but either way it wont be available in the short term if at all. I would merge this as is I dont think we need to wait for resizing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#discussion_r548324992
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/queues.js
##########
@@ -59,28 +60,76 @@ var Artemis;
function QueuesController($scope, workspace, jolokia, localStorage, artemisMessage, $location, $timeout, $filter, $sanitize, pagination, artemisQueue, artemisAddress) {
var ctrl = this;
ctrl.pagination = pagination;
+ ctrl.pagination.reset();
var mbean = Artemis.getBrokerMBean(workspace, jolokia);
ctrl.allAddresses = [];
ctrl.queues = [];
ctrl.workspace = workspace;
ctrl.refreshed = false;
+ ctrl.dtOptions = {
+ // turn of ordering as we do it ourselves
+ ordering: false,
+ columns: [
+ {name: "ID", visible: true},
+ {name: "name", visible: true},
+ {name: "Address", visible: true},
+ {name: "Routing Type", visible: true},
+ {name: "Filter", visible: true},
+ {name: "Durable", visible: true},
+ {name: "Max Consumers", visible: true},
+ {name: "Purge On No Consumers", visible: true},
+ {name: "Consumer Count", visible: true},
+ {name: "Rate", visible: true},
+ {name: "Message Count", visible: true},
+ {name: "Paused", visible: false},
+ {name: "Temporary", visible: false},
+ {name: "Auto Created", visible: false},
+ {name: "User", visible: false},
+ {name: "Total Messages Added", visible: false},
+ {name: "Total Messages Acked", visible: false},
+ {name: "Delivering Count", visible: false},
+ {name: "Messages Killed", visible: false},
+ {name: "Direct Deliver", visible: false},
+ {name: "Exclusive", visible: false},
+ {name: "last value", visible: false},
Review comment:
What about LastValueKey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] sebthom commented on a change in pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
sebthom commented on a change in pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#discussion_r548320978
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/addresses.js
##########
@@ -59,17 +60,43 @@ var Artemis;
function AddressesController($scope, workspace, jolokia, localStorage, artemisMessage, $location, $timeout, $filter, $sanitize, pagination, artemisAddress) {
var ctrl = this;
ctrl.pagination = pagination;
+ ctrl.pagination.reset();
var mbean = Artemis.getBrokerMBean(workspace, jolokia);
ctrl.allAddresses = [];
ctrl.addresses = [];
ctrl.workspace = workspace;
ctrl.refreshed = false;
+ ctrl.dtOptions = {
+ // turn of ordering as we do it ourselves
+ ordering: false,
+ columns: [
+ {name: "ID", visible: true},
+ {name: "Name", visible: true},
+ {name: "Routing Types", visible: true},
+ {name: "Queue Count", visible: true}
+ ]
+ };
+
+ Artemis.log.debug('sessionStorage: addressColumnDefs =', localStorage.getItem('addressColumnDefs'));
+ if (localStorage.getItem('addressColumnDefs')) {
+ ctrl.dtOptions.columns = JSON.parse(localStorage.getItem('addressColumnDefs'));
+ }
+
+ ctrl.updateColumns = function () {
+ var attributes = [];
+ ctrl.dtOptions.columns.forEach(function (column) {
+ attributes.push({name: column.name, visible: column.visible});
+ });
+ Artemis.log.debug("saving columns " + JSON.stringify(attributes));
+ localStorage.setItem('addressColumnDefs', JSON.stringify(attributes));
+ }
+
ctrl.filter = {
fieldOptions: [
- {id: 'ID', name: 'ID'},
- {id: 'NAME', name: 'Name'},
- {id: 'ROUTING_TYPES', name: 'Queue Count'},
- {id: 'QUEUE_COUNT', name: 'User'}
+ {id: 'id', name: 'ID'},
+ {id: 'name', name: 'Name'},
+ {id: 'routingTypes', name: 'Queue Count'},
Review comment:
Can you also fix the name attribute for this and the next field? I think they are mixed up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#discussion_r548325975
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/queues.js
##########
@@ -59,28 +60,76 @@ var Artemis;
function QueuesController($scope, workspace, jolokia, localStorage, artemisMessage, $location, $timeout, $filter, $sanitize, pagination, artemisQueue, artemisAddress) {
var ctrl = this;
ctrl.pagination = pagination;
+ ctrl.pagination.reset();
var mbean = Artemis.getBrokerMBean(workspace, jolokia);
ctrl.allAddresses = [];
ctrl.queues = [];
ctrl.workspace = workspace;
ctrl.refreshed = false;
+ ctrl.dtOptions = {
+ // turn of ordering as we do it ourselves
+ ordering: false,
+ columns: [
+ {name: "ID", visible: true},
+ {name: "name", visible: true},
+ {name: "Address", visible: true},
+ {name: "Routing Type", visible: true},
+ {name: "Filter", visible: true},
+ {name: "Durable", visible: true},
+ {name: "Max Consumers", visible: true},
+ {name: "Purge On No Consumers", visible: true},
+ {name: "Consumer Count", visible: true},
Review comment:
a few more queue fields/values missing: "Consumers Before Dispatch" & "Delay Before Dispatch"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756620608
Also i raised this on the original PR's that did the hawtio2 change, but seems the comments i left got missed with the changes to console being done, can the docs please be updated, they still are about/ images of original console version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#discussion_r548325472
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/queues.js
##########
@@ -59,28 +60,76 @@ var Artemis;
function QueuesController($scope, workspace, jolokia, localStorage, artemisMessage, $location, $timeout, $filter, $sanitize, pagination, artemisQueue, artemisAddress) {
var ctrl = this;
ctrl.pagination = pagination;
+ ctrl.pagination.reset();
var mbean = Artemis.getBrokerMBean(workspace, jolokia);
ctrl.allAddresses = [];
ctrl.queues = [];
ctrl.workspace = workspace;
ctrl.refreshed = false;
+ ctrl.dtOptions = {
+ // turn of ordering as we do it ourselves
+ ordering: false,
+ columns: [
Review comment:
Ring Size field is missing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-752018405
I’m not 100% which datatables impl you’re using but a quick Google fu:
https://datatables.net/forums/discussion/26786/basic-column-resizing-plugin
https://www.gyrocode.com/articles/jquery-datatables-column-reordering-and-resizing/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] sebthom commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
sebthom commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-750581233
Never mind, it is already fixed by your PR. It just isn't mentioned in the JIRA issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756367833
Why has this closed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756618938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#discussion_r548324899
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/queues.js
##########
@@ -59,28 +60,76 @@ var Artemis;
function QueuesController($scope, workspace, jolokia, localStorage, artemisMessage, $location, $timeout, $filter, $sanitize, pagination, artemisQueue, artemisAddress) {
var ctrl = this;
ctrl.pagination = pagination;
+ ctrl.pagination.reset();
var mbean = Artemis.getBrokerMBean(workspace, jolokia);
ctrl.allAddresses = [];
ctrl.queues = [];
ctrl.workspace = workspace;
ctrl.refreshed = false;
+ ctrl.dtOptions = {
+ // turn of ordering as we do it ourselves
+ ordering: false,
+ columns: [
+ {name: "ID", visible: true},
+ {name: "name", visible: true},
+ {name: "Address", visible: true},
+ {name: "Routing Type", visible: true},
+ {name: "Filter", visible: true},
+ {name: "Durable", visible: true},
+ {name: "Max Consumers", visible: true},
+ {name: "Purge On No Consumers", visible: true},
+ {name: "Consumer Count", visible: true},
+ {name: "Rate", visible: true},
+ {name: "Message Count", visible: true},
+ {name: "Paused", visible: false},
+ {name: "Temporary", visible: false},
+ {name: "Auto Created", visible: false},
+ {name: "User", visible: false},
+ {name: "Total Messages Added", visible: false},
+ {name: "Total Messages Acked", visible: false},
+ {name: "Delivering Count", visible: false},
+ {name: "Messages Killed", visible: false},
+ {name: "Direct Deliver", visible: false},
+ {name: "Exclusive", visible: false},
+ {name: "last value", visible: false},
Review comment:
**L**ast**V**alue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] sebthom commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
sebthom commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-750567179
@andytaylor do you think you could also fix server side sorting? I realized yesterday that for example on the addresses and queues view the sorting does not work across across pages. I think it is because column ids in the Javascript files are upper case but the server control mbean uses lower or camelcase amd thus does not interpret the selected sort column correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-752023625
cheers @michaelandrepearce i'll take a look in the new year
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756618938
It was waiting on Andy to look at column resizing which he was going to sort this side of new year and was waiting on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#discussion_r548324823
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/queues.js
##########
@@ -59,28 +60,76 @@ var Artemis;
function QueuesController($scope, workspace, jolokia, localStorage, artemisMessage, $location, $timeout, $filter, $sanitize, pagination, artemisQueue, artemisAddress) {
var ctrl = this;
ctrl.pagination = pagination;
+ ctrl.pagination.reset();
var mbean = Artemis.getBrokerMBean(workspace, jolokia);
ctrl.allAddresses = [];
ctrl.queues = [];
ctrl.workspace = workspace;
ctrl.refreshed = false;
+ ctrl.dtOptions = {
+ // turn of ordering as we do it ourselves
+ ordering: false,
+ columns: [
Review comment:
Queue Enabled/Disabled field is missing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756657865
@michaelandrepearce I'll update the docs before next week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#discussion_r548324899
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/queues.js
##########
@@ -59,28 +60,76 @@ var Artemis;
function QueuesController($scope, workspace, jolokia, localStorage, artemisMessage, $location, $timeout, $filter, $sanitize, pagination, artemisQueue, artemisAddress) {
var ctrl = this;
ctrl.pagination = pagination;
+ ctrl.pagination.reset();
var mbean = Artemis.getBrokerMBean(workspace, jolokia);
ctrl.allAddresses = [];
ctrl.queues = [];
ctrl.workspace = workspace;
ctrl.refreshed = false;
+ ctrl.dtOptions = {
+ // turn of ordering as we do it ourselves
+ ordering: false,
+ columns: [
+ {name: "ID", visible: true},
+ {name: "name", visible: true},
+ {name: "Address", visible: true},
+ {name: "Routing Type", visible: true},
+ {name: "Filter", visible: true},
+ {name: "Durable", visible: true},
+ {name: "Max Consumers", visible: true},
+ {name: "Purge On No Consumers", visible: true},
+ {name: "Consumer Count", visible: true},
+ {name: "Rate", visible: true},
+ {name: "Message Count", visible: true},
+ {name: "Paused", visible: false},
+ {name: "Temporary", visible: false},
+ {name: "Auto Created", visible: false},
+ {name: "User", visible: false},
+ {name: "Total Messages Added", visible: false},
+ {name: "Total Messages Acked", visible: false},
+ {name: "Delivering Count", visible: false},
+ {name: "Messages Killed", visible: false},
+ {name: "Direct Deliver", visible: false},
+ {name: "Exclusive", visible: false},
+ {name: "last value", visible: false},
Review comment:
**L**ast **V**alue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756620608
Also i raised this on the original PR's that did the hawtio2 change, but seems the comments i left got missed with the changes to console being done, can the docs please be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] sebthom removed a comment on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
sebthom removed a comment on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-750581233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756683166
just fyi my column resizing wip is at https://github.com/andytaylor/activemq-artemis/tree/resizing
im currently blocked on at first glance looks like a bug in Angular
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756620608
Also i raised this on the original PR's that did the hawtio2 change, but seems the comments i left got missed with the changes to console being done, can the docs please be updated, they still are about/ images of original console version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756497945
@michaelandrepearce it's merged.. shouldn't it be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-751666673
> Can we add back ability to change column widths?
Unfortunately I have no idea whether this is even possible, there is nothing in datatables to do this which i what hawtIO2 now uses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-756656704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on pull request #3389: ARTEMIS-3043 - improvements on new console
Posted by GitBox <gi...@apache.org>.
andytaylor commented on pull request #3389:
URL: https://github.com/apache/activemq-artemis/pull/3389#issuecomment-752014764
just fyi, I'll try and address column resizing separately, see if i can find a solution with datatables and dt-options
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org