You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Stanislav Kozlovski <st...@confluent.io> on 2018/08/07 11:19:34 UTC
[VOTE] KIP-346 - Improve LogCleaner behavior on error
Hey everybody,
I'm starting a vote on KIP-346
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error>
--
Best,
Stanislav
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Stanislav Kozlovski <st...@confluent.io>.
Hi,
I just wanted to remind everybody that the this KIP has been accepted. The
only thing left is for it to pass PR reviews and get merged for 2.1. PR:
https://github.com/apache/kafka/pull/5439
On Fri, Aug 24, 2018 at 11:12 AM Stanislav Kozlovski <st...@confluent.io>
wrote:
> Hi Jun,
>
> Yes, my intention was to have them per logDir but I failed to mention it
> in the KIP. Updated.
>
> Thanks,
> Stan
>
> On Fri, Aug 24, 2018 at 12:00 AM Jun Rao <ju...@confluent.io> wrote:
>
>> Hi, Stan,
>>
>> Thanks for the KIP. Looks good to me overall. Just one comment below.
>>
>> uncleanable-partitions-count is per logDir, but uncleanable-bytes is not.
>> Should we make them consistent?
>>
>> Jun
>>
>>
>> On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski <
>> stanislav@confluent.io
>> > wrote:
>>
>> > Hi everybody,
>> >
>> > @Jason - I've updated the section. Thanks for the reminder
>> >
>> > I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
>> > Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael,
>> Manikumar,
>> > Ray, Ted, Thomas).
>> >
>> > The PR is ready for review at https://github.com/apache/kafka/pull/5439
>> >
>> > On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson <ja...@confluent.io>
>> > wrote:
>> >
>> > > +1 Thanks for the KIP! I'd suggest mentioning the configurations that
>> > were
>> > > previously proposed in the rejected alternatives section. We may
>> > reconsider
>> > > them in the future.
>> > >
>> > > On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah <dh...@confluent.io>
>> > > wrote:
>> > >
>> > > > Thanks for the KIP, Stanislav! +1 (non-binding)
>> > > >
>> > > > - Dhruvil
>> > > >
>> > > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <cm...@apache.org>
>> > wrote:
>> > > >
>> > > > > +1 (non-binding)
>> > > > >
>> > > > > best,
>> > > > > Colin
>> > > > >
>> > > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
>> > > > > > Hey everybody,
>> > > > > > I'm starting a vote on KIP-346
>> > > > > > <
>> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> > > > 346+-+Improve+LogCleaner+behavior+on+error
>> > > > > >
>> > > > > >
>> > > > > > --
>> > > > > > Best,
>> > > > > > Stanislav
>> > > > >
>> > > >
>> > >
>> >
>> >
>> > --
>> > Best,
>> > Stanislav
>> >
>>
>
>
> --
> Best,
> Stanislav
>
--
Best,
Stanislav
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Stanislav Kozlovski <st...@confluent.io>.
Hi Jun,
Yes, my intention was to have them per logDir but I failed to mention it in
the KIP. Updated.
Thanks,
Stan
On Fri, Aug 24, 2018 at 12:00 AM Jun Rao <ju...@confluent.io> wrote:
> Hi, Stan,
>
> Thanks for the KIP. Looks good to me overall. Just one comment below.
>
> uncleanable-partitions-count is per logDir, but uncleanable-bytes is not.
> Should we make them consistent?
>
> Jun
>
>
> On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski <
> stanislav@confluent.io
> > wrote:
>
> > Hi everybody,
> >
> > @Jason - I've updated the section. Thanks for the reminder
> >
> > I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
> > Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael,
> Manikumar,
> > Ray, Ted, Thomas).
> >
> > The PR is ready for review at https://github.com/apache/kafka/pull/5439
> >
> > On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson <ja...@confluent.io>
> > wrote:
> >
> > > +1 Thanks for the KIP! I'd suggest mentioning the configurations that
> > were
> > > previously proposed in the rejected alternatives section. We may
> > reconsider
> > > them in the future.
> > >
> > > On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah <dh...@confluent.io>
> > > wrote:
> > >
> > > > Thanks for the KIP, Stanislav! +1 (non-binding)
> > > >
> > > > - Dhruvil
> > > >
> > > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <cm...@apache.org>
> > wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > best,
> > > > > Colin
> > > > >
> > > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > > > > Hey everybody,
> > > > > > I'm starting a vote on KIP-346
> > > > > > <
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 346+-+Improve+LogCleaner+behavior+on+error
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best,
> > > > > > Stanislav
> > > > >
> > > >
> > >
> >
> >
> > --
> > Best,
> > Stanislav
> >
>
--
Best,
Stanislav
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Jun Rao <ju...@confluent.io>.
Hi, Stan,
Thanks for the KIP. Looks good to me overall. Just one comment below.
uncleanable-partitions-count is per logDir, but uncleanable-bytes is not.
Should we make them consistent?
Jun
On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski <stanislav@confluent.io
> wrote:
> Hi everybody,
>
> @Jason - I've updated the section. Thanks for the reminder
>
> I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
> Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael, Manikumar,
> Ray, Ted, Thomas).
>
> The PR is ready for review at https://github.com/apache/kafka/pull/5439
>
> On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson <ja...@confluent.io>
> wrote:
>
> > +1 Thanks for the KIP! I'd suggest mentioning the configurations that
> were
> > previously proposed in the rejected alternatives section. We may
> reconsider
> > them in the future.
> >
> > On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah <dh...@confluent.io>
> > wrote:
> >
> > > Thanks for the KIP, Stanislav! +1 (non-binding)
> > >
> > > - Dhruvil
> > >
> > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <cm...@apache.org>
> wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > best,
> > > > Colin
> > > >
> > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > > > Hey everybody,
> > > > > I'm starting a vote on KIP-346
> > > > > <
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 346+-+Improve+LogCleaner+behavior+on+error
> > > > >
> > > > >
> > > > > --
> > > > > Best,
> > > > > Stanislav
> > > >
> > >
> >
>
>
> --
> Best,
> Stanislav
>
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Stanislav Kozlovski <st...@confluent.io>.
Hi everybody,
@Jason - I've updated the section. Thanks for the reminder
I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael, Manikumar,
Ray, Ted, Thomas).
The PR is ready for review at https://github.com/apache/kafka/pull/5439
On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson <ja...@confluent.io> wrote:
> +1 Thanks for the KIP! I'd suggest mentioning the configurations that were
> previously proposed in the rejected alternatives section. We may reconsider
> them in the future.
>
> On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah <dh...@confluent.io>
> wrote:
>
> > Thanks for the KIP, Stanislav! +1 (non-binding)
> >
> > - Dhruvil
> >
> > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <cm...@apache.org> wrote:
> >
> > > +1 (non-binding)
> > >
> > > best,
> > > Colin
> > >
> > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > > Hey everybody,
> > > > I'm starting a vote on KIP-346
> > > > <
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 346+-+Improve+LogCleaner+behavior+on+error
> > > >
> > > >
> > > > --
> > > > Best,
> > > > Stanislav
> > >
> >
>
--
Best,
Stanislav
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Jason Gustafson <ja...@confluent.io>.
+1 Thanks for the KIP! I'd suggest mentioning the configurations that were
previously proposed in the rejected alternatives section. We may reconsider
them in the future.
On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah <dh...@confluent.io> wrote:
> Thanks for the KIP, Stanislav! +1 (non-binding)
>
> - Dhruvil
>
> On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <cm...@apache.org> wrote:
>
> > +1 (non-binding)
> >
> > best,
> > Colin
> >
> > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > Hey everybody,
> > > I'm starting a vote on KIP-346
> > > <
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 346+-+Improve+LogCleaner+behavior+on+error
> > >
> > >
> > > --
> > > Best,
> > > Stanislav
> >
>
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Dhruvil Shah <dh...@confluent.io>.
Thanks for the KIP, Stanislav! +1 (non-binding)
- Dhruvil
On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <cm...@apache.org> wrote:
> +1 (non-binding)
>
> best,
> Colin
>
> On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > Hey everybody,
> > I'm starting a vote on KIP-346
> > <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> >
> >
> > --
> > Best,
> > Stanislav
>
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Colin McCabe <cm...@apache.org>.
+1 (non-binding)
best,
Colin
On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> Hey everybody,
> I'm starting a vote on KIP-346
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error>
>
> --
> Best,
> Stanislav
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Harsha <ka...@harsha.io>.
+1 (binding)
Thanks,
Harsha
On Tue, Aug 7, 2018, at 10:22 AM, Manikumar wrote:
> +1 (non-binding)
>
> Thanks for the KIP.
>
> On Tue, Aug 7, 2018 at 10:42 PM Ray Chiang <rc...@apache.org> wrote:
>
> > +1 (non-binding)
> >
> > -Ray
> >
> > On 8/7/18 9:26 AM, Ted Yu wrote:
> > > +1
> > >
> > > On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker <Th...@tivo.com>
> > wrote:
> > >
> > >> +1 (non-binding)
> > >>
> > >> We've hit issues with the log cleaner in the past, and this would be a
> > >> great improvement.
> > >> On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
> > >>
> > >> Hey everybody,
> > >>
> > >> I'm starting a vote on KIP-346
> > >>
> > >> <
> > >>
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> > >>
> > >>
> > >> ________________________________
> > >>
> > >> This email and any attachments may contain confidential and privileged
> > >> material for the sole use of the intended recipient. Any review,
> > copying,
> > >> or distribution of this email (or any attachments) by others is
> > prohibited.
> > >> If you are not the intended recipient, please contact the sender
> > >> immediately and permanently delete this email and any attachments. No
> > >> employee or agent of TiVo Inc. is authorized to conclude any binding
> > >> agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
> > >> Inc. may only be made by a signed written agreement.
> > >>
> >
> >
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Manikumar <ma...@gmail.com>.
+1 (non-binding)
Thanks for the KIP.
On Tue, Aug 7, 2018 at 10:42 PM Ray Chiang <rc...@apache.org> wrote:
> +1 (non-binding)
>
> -Ray
>
> On 8/7/18 9:26 AM, Ted Yu wrote:
> > +1
> >
> > On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker <Th...@tivo.com>
> wrote:
> >
> >> +1 (non-binding)
> >>
> >> We've hit issues with the log cleaner in the past, and this would be a
> >> great improvement.
> >> On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
> >>
> >> Hey everybody,
> >>
> >> I'm starting a vote on KIP-346
> >>
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> >>
> >>
> >> ________________________________
> >>
> >> This email and any attachments may contain confidential and privileged
> >> material for the sole use of the intended recipient. Any review,
> copying,
> >> or distribution of this email (or any attachments) by others is
> prohibited.
> >> If you are not the intended recipient, please contact the sender
> >> immediately and permanently delete this email and any attachments. No
> >> employee or agent of TiVo Inc. is authorized to conclude any binding
> >> agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
> >> Inc. may only be made by a signed written agreement.
> >>
>
>
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Ray Chiang <rc...@apache.org>.
+1 (non-binding)
-Ray
On 8/7/18 9:26 AM, Ted Yu wrote:
> +1
>
> On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker <Th...@tivo.com> wrote:
>
>> +1 (non-binding)
>>
>> We've hit issues with the log cleaner in the past, and this would be a
>> great improvement.
>> On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
>>
>> Hey everybody,
>>
>> I'm starting a vote on KIP-346
>>
>> <
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
>>
>>
>> ________________________________
>>
>> This email and any attachments may contain confidential and privileged
>> material for the sole use of the intended recipient. Any review, copying,
>> or distribution of this email (or any attachments) by others is prohibited.
>> If you are not the intended recipient, please contact the sender
>> immediately and permanently delete this email and any attachments. No
>> employee or agent of TiVo Inc. is authorized to conclude any binding
>> agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
>> Inc. may only be made by a signed written agreement.
>>
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Ted Yu <yu...@gmail.com>.
+1
On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker <Th...@tivo.com> wrote:
> +1 (non-binding)
>
> We've hit issues with the log cleaner in the past, and this would be a
> great improvement.
> On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
>
> Hey everybody,
>
> I'm starting a vote on KIP-346
>
> <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> >
>
>
>
> ________________________________
>
> This email and any attachments may contain confidential and privileged
> material for the sole use of the intended recipient. Any review, copying,
> or distribution of this email (or any attachments) by others is prohibited.
> If you are not the intended recipient, please contact the sender
> immediately and permanently delete this email and any attachments. No
> employee or agent of TiVo Inc. is authorized to conclude any binding
> agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
> Inc. may only be made by a signed written agreement.
>
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Thomas Becker <Th...@tivo.com>.
+1 (non-binding)
We've hit issues with the log cleaner in the past, and this would be a great improvement.
On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
Hey everybody,
I'm starting a vote on KIP-346
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error>
________________________________
This email and any attachments may contain confidential and privileged material for the sole use of the intended recipient. Any review, copying, or distribution of this email (or any attachments) by others is prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete this email and any attachments. No employee or agent of TiVo Inc. is authorized to conclude any binding agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo Inc. may only be made by a signed written agreement.
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Mickael Maison <mi...@gmail.com>.
+1 (non-binding)
Thanks for the KIP!
On Tue, Aug 7, 2018 at 6:53 PM Gwen Shapira <gw...@confluent.io> wrote:
>
> +1 (binding)
>
> On Tue, Aug 7, 2018 at 4:19 AM, Stanislav Kozlovski <st...@confluent.io>
> wrote:
>
> > Hey everybody,
> > I'm starting a vote on KIP-346
> > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 346+-+Improve+LogCleaner+behavior+on+error>
> >
> > --
> > Best,
> > Stanislav
> >
>
>
>
> --
> *Gwen Shapira*
> Product Manager | Confluent
> 650.450.2760 | @gwenshap
> Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> <http://www.confluent.io/blog>
Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error
Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding)
On Tue, Aug 7, 2018 at 4:19 AM, Stanislav Kozlovski <st...@confluent.io>
wrote:
> Hey everybody,
> I'm starting a vote on KIP-346
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 346+-+Improve+LogCleaner+behavior+on+error>
>
> --
> Best,
> Stanislav
>
--
*Gwen Shapira*
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
<http://www.confluent.io/blog>