You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2015/11/01 18:16:27 UTC

[jira] [Updated] (FLINK-2914) Missing break in ZooKeeperSubmittedJobGraphStore#SubmittedJobGraphsPathCacheListener#childEvent()

     [ https://issues.apache.org/jira/browse/FLINK-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated FLINK-2914:
--------------------------
    Description: 
{code}
        case CONNECTION_SUSPENDED:
          LOG.warn("ZooKeeper connection SUSPENDED. Changes to the submitted job " +
              "graphs are not monitored (temporarily).");

        case CONNECTION_LOST:
          LOG.warn("ZooKeeper connection LOST. Changes to the submitted job " +
              "graphs are not monitored (permanently).");
          break;

        case CONNECTION_RECONNECTED:
          LOG.info("ZooKeeper connection RECONNECTED. Changes to the submitted job " +
              "graphs are monitored again.");

        case INITIALIZED:
          LOG.info("SubmittedJobGraphsPathCacheListener initialized");
          break;
{code}

For CONNECTION_SUSPENDED and CONNECTION_RECONNECTED, the break statement is missing.
This would result in unrelated event logging.

  was:
{code}
        case CONNECTION_SUSPENDED:
          LOG.warn("ZooKeeper connection SUSPENDED. Changes to the submitted job " +
              "graphs are not monitored (temporarily).");

        case CONNECTION_LOST:
          LOG.warn("ZooKeeper connection LOST. Changes to the submitted job " +
              "graphs are not monitored (permanently).");
          break;

        case CONNECTION_RECONNECTED:
          LOG.info("ZooKeeper connection RECONNECTED. Changes to the submitted job " +
              "graphs are monitored again.");

        case INITIALIZED:
          LOG.info("SubmittedJobGraphsPathCacheListener initialized");
          break;
{code}
For CONNECTION_SUSPENDED and CONNECTION_RECONNECTED, the break statement is missing.
This would result in unrelated event logging.


> Missing break in ZooKeeperSubmittedJobGraphStore#SubmittedJobGraphsPathCacheListener#childEvent()
> -------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-2914
>                 URL: https://issues.apache.org/jira/browse/FLINK-2914
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>         case CONNECTION_SUSPENDED:
>           LOG.warn("ZooKeeper connection SUSPENDED. Changes to the submitted job " +
>               "graphs are not monitored (temporarily).");
>         case CONNECTION_LOST:
>           LOG.warn("ZooKeeper connection LOST. Changes to the submitted job " +
>               "graphs are not monitored (permanently).");
>           break;
>         case CONNECTION_RECONNECTED:
>           LOG.info("ZooKeeper connection RECONNECTED. Changes to the submitted job " +
>               "graphs are monitored again.");
>         case INITIALIZED:
>           LOG.info("SubmittedJobGraphsPathCacheListener initialized");
>           break;
> {code}
> For CONNECTION_SUSPENDED and CONNECTION_RECONNECTED, the break statement is missing.
> This would result in unrelated event logging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)