[GitHub] [ozone] adoroszlai commented on pull request #4821: HDDS-8748. Reduce DN IO times when deleteChunk (FilePerBlockStrategy)

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on PR #4821:
URL: https://github.com/apache/ozone/pull/4821#issuecomment-1577352845

   @xichen01 What I meant is that this statement:
   
   > For non-existent files, the `FilePerBlockStrategy#deleteChunk' function behaves the same as before the change, the only difference is that it prints a log of successful deletions.
   
   is true only for the case when `verifyLength=true`, i.e. the delete single chunk code path, which is not the one exercised by block deleting service.  For the latter, it is equivalent to simply removing the check.
   
   I'm OK with performing these checks and logging the messages only at debug level, if we can confirm that block deleting service provides other ways to understand what it's doing, or that the messages are basically useless.
   
   In other words, we need to balance performance and observability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org