You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2016/06/28 13:44:58 UTC
svn commit: r1750507 - /httpd/httpd/trunk/modules/proxy/balancers/config2.m4
Author: wrowe
Date: Tue Jun 28 13:44:58 2016
New Revision: 1750507
URL: http://svn.apache.org/viewvc?rev=1750507&view=rev
Log:
Fix proxy balancer lbmethod --enable defaults to follow proxy_balancer
Modified:
httpd/httpd/trunk/modules/proxy/balancers/config2.m4
Modified: httpd/httpd/trunk/modules/proxy/balancers/config2.m4
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/balancers/config2.m4?rev=1750507&r1=1750506&r2=1750507&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/balancers/config2.m4 (original)
+++ httpd/httpd/trunk/modules/proxy/balancers/config2.m4 Tue Jun 28 13:44:58 2016
@@ -1,8 +1,8 @@
APACHE_MODPATH_INIT(proxy/balancers)
-APACHE_MODULE(lbmethod_byrequests, Apache proxy Load balancing by request counting, , , $proxy_mods_enable)
-APACHE_MODULE(lbmethod_bytraffic, Apache proxy Load balancing by traffic counting, , , $proxy_mods_enable)
-APACHE_MODULE(lbmethod_bybusyness, Apache proxy Load balancing by busyness, , , $proxy_mods_enable)
-APACHE_MODULE(lbmethod_heartbeat, Apache proxy Load balancing from Heartbeats, , , $proxy_mods_enable)
+APACHE_MODULE(lbmethod_byrequests, Apache proxy Load balancing by request counting, , , $enable_proxy_balancer, , proxy_balancer)
+APACHE_MODULE(lbmethod_bytraffic, Apache proxy Load balancing by traffic counting, , , $enable_proxy_balancer, , proxy_balancer)
+APACHE_MODULE(lbmethod_bybusyness, Apache proxy Load balancing by busyness, , , $enable_proxy_balancer, , proxy_balancer)
+APACHE_MODULE(lbmethod_heartbeat, Apache proxy Load balancing from Heartbeats, , , $enable_proxy_balancer, , proxy_balancer)
APACHE_MODPATH_FINISH
Re: svn commit: r1750507 - /httpd/httpd/trunk/modules/proxy/balancers/config2.m4
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
This patch alone was insufficient, in a stock ./configure with
the default settings of 'most', 'shared', we don't have lbmodules
(thanks to Jens again for calling this out).
Ranier, can you shed light on one line from your commit
https://svn.apache.org/viewvc?view=revision&revision=952007
I think this patch should get us back to a state where the
enable_foomodule= value isn't unset for shared modules...
--- acinclude.m4 (revision 1750505)
+++ acinclude.m4 (working copy)
@@ -424,7 +424,6 @@
fi
shared="";;
*)
- enable_$1=`echo $enable_$1|sed 's/shared,*//'`
sharedobjs=yes
shared=yes
DSO_MODULES="$DSO_MODULES $1"
But I'm wondering why "unsetting" the enable_foomodule=shared
result was a good idea in the first place, maybe you have some
recollection of what that line of code was about?
Cheers,
Bill
On Tue, Jun 28, 2016 at 8:44 AM, <wr...@apache.org> wrote:
> Author: wrowe
> Date: Tue Jun 28 13:44:58 2016
> New Revision: 1750507
>
> URL: http://svn.apache.org/viewvc?rev=1750507&view=rev
> Log:
> Fix proxy balancer lbmethod --enable defaults to follow proxy_balancer
>
> Modified:
> httpd/httpd/trunk/modules/proxy/balancers/config2.m4
>
> Modified: httpd/httpd/trunk/modules/proxy/balancers/config2.m4
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/balancers/config2.m4?rev=1750507&r1=1750506&r2=1750507&view=diff
>
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/balancers/config2.m4 (original)
> +++ httpd/httpd/trunk/modules/proxy/balancers/config2.m4 Tue Jun 28
> 13:44:58 2016
> @@ -1,8 +1,8 @@
> APACHE_MODPATH_INIT(proxy/balancers)
>
> -APACHE_MODULE(lbmethod_byrequests, Apache proxy Load balancing by request
> counting, , , $proxy_mods_enable)
> -APACHE_MODULE(lbmethod_bytraffic, Apache proxy Load balancing by traffic
> counting, , , $proxy_mods_enable)
> -APACHE_MODULE(lbmethod_bybusyness, Apache proxy Load balancing by
> busyness, , , $proxy_mods_enable)
> -APACHE_MODULE(lbmethod_heartbeat, Apache proxy Load balancing from
> Heartbeats, , , $proxy_mods_enable)
> +APACHE_MODULE(lbmethod_byrequests, Apache proxy Load balancing by request
> counting, , , $enable_proxy_balancer, , proxy_balancer)
> +APACHE_MODULE(lbmethod_bytraffic, Apache proxy Load balancing by traffic
> counting, , , $enable_proxy_balancer, , proxy_balancer)
> +APACHE_MODULE(lbmethod_bybusyness, Apache proxy Load balancing by
> busyness, , , $enable_proxy_balancer, , proxy_balancer)
> +APACHE_MODULE(lbmethod_heartbeat, Apache proxy Load balancing from
> Heartbeats, , , $enable_proxy_balancer, , proxy_balancer)
>
> APACHE_MODPATH_FINISH
>
>
>