You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/18 16:16:52 UTC
[GitHub] [dolphinscheduler] huangfox opened a new issue #6916: [Bug] [dolphinscheduler-api]
huangfox opened a new issue #6916:
URL: https://github.com/apache/dolphinscheduler/issues/6916
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
1. Edit an **correct** MySql datasource (saved before and passed verification), and then click the "test connect" button, but can't connect the MySql datasource.
See the part of "How to reproduce" for details.
### What you expected to happen
1. Edit an correct MySql datasource, and then click the "test connect" button, return to connect successfully.
### How to reproduce
1. Create an correct MySql datasource, and save.
2. **Restart the dolphinscheduler-api server. (must do this step)**
3. Edit the MySql datasource, and click the "test connect" button.
4. Connection failed
### Anything else
1. When edit an MySql datasource, the front-end page post a "test connect" request to the dolphinScheduler-api server. The request body that is object of BaseDataSourceParamDTO contains a null password field.
2. The object of BaseDataSourceParam will be verified before initializing the data source client. If the password is null a default password (123456) will to set.
The verification code is [here](https://github.com/apache/dolphinscheduler/blob/4114cb07f64950f88ffb4aa8a4ecc4815f32d76b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/client/CommonDataSourceClient.java#L71).
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Narcasserun commented on issue #6916: [Bug] [dolphinscheduler-api] Edit a correct MySql datasource, "test connect" failed.
Posted by GitBox <gi...@apache.org>.
Narcasserun commented on issue #6916:
URL: https://github.com/apache/dolphinscheduler/issues/6916#issuecomment-975541378
You need to re-enter the password when editing the data source
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangfox commented on issue #6916: [Bug] [dolphinscheduler-api] Edit a correct MySql datasource, "test connect" failed.
Posted by GitBox <gi...@apache.org>.
huangfox commented on issue #6916:
URL: https://github.com/apache/dolphinscheduler/issues/6916#issuecomment-978727717
> You need to re-enter the password when editing the data source
I see, thanks for your reply.
In my personal opinion, this way will cause some confusion to users.
In another case, if the database does not have a password, how to configure the data source? (If the password is null a default password (123456) will to set.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangfox closed issue #6916: [Bug] [dolphinscheduler-api] Edit a correct MySql datasource, "test connect" failed.
Posted by GitBox <gi...@apache.org>.
huangfox closed issue #6916:
URL: https://github.com/apache/dolphinscheduler/issues/6916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangfox edited a comment on issue #6916: [Bug] [dolphinscheduler-api] Edit a correct MySql datasource, "test connect" failed.
Posted by GitBox <gi...@apache.org>.
huangfox edited a comment on issue #6916:
URL: https://github.com/apache/dolphinscheduler/issues/6916#issuecomment-978727717
> You need to re-enter the password when editing the data source
I see, thanks for your reply.
In my personal opinion, this way will cause some confusion to users.
In another case, if the database does not have a password, how to configure the data source? (If the password is null a default password (123456) will to set.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangfox edited a comment on issue #6916: [Bug] [dolphinscheduler-api] Edit a correct MySql datasource, "test connect" failed.
Posted by GitBox <gi...@apache.org>.
huangfox edited a comment on issue #6916:
URL: https://github.com/apache/dolphinscheduler/issues/6916#issuecomment-978727717
> You need to re-enter the password when editing the data source
I see, thanks for your reply. @Narcasserun
In my personal opinion, this way will cause some confusion to users.
In another case, if the database does not have a password, how to configure the data source? (If the password is null a default password (123456) will to set.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #6916: [Bug] [dolphinscheduler-api]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #6916:
URL: https://github.com/apache/dolphinscheduler/issues/6916#issuecomment-973017853
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org