You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Robert Bradshaw <ro...@google.com> on 2018/03/07 18:18:58 UTC

Re: [CANCEL][VOTE] Release 2.4.0, release candidate #1

Done.

I'm also looking into the direct runner nexmark regression Ismael reported.
Does anyone know how this code has changed since the last release?

On Wed, Mar 7, 2018 at 10:09 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:

> Thanks for the update Robert.
>
> Can you please set the thread subject to "[CANCEL][VOTE] Release 2.4.0,
> release
> candidate #1" for the tracking ?
>
> Regards
> JB
>
> On 03/07/2018 07:04 PM, Robert Bradshaw wrote:
> > I'm canceling this RC. Hope to get another one out shortly (but if you
> notice
> > items in the meantime, let me know). This is my first (full) release, so
> I'm
> > still learning the ropes.
> >
> >
> > On Wed, Mar 7, 2018 at 9:55 AM Jean-Baptiste Onofré <jb@nanthrax.net
> > <ma...@nanthrax.net>> wrote:
> >
> >     I don't see the staging repo on repository.apache.org
> >     <http://repository.apache.org> anymore.
> >
> >     Maybe Robert already dropped it due to -1. If it's the case, he
> should have sent
> >     the [CANCEL] e-mail first.
> >
> >     Regards
> >     JB
> >
> >     On 03/07/2018 06:51 PM, Alan Myrvold wrote:
> >     > I don't see anything published
> >     > to
> https://repository.apache.org/content/repositories/orgapachebeam-1028/ ?
> >     >
> >     >
> >     > On Wed, Mar 7, 2018 at 9:26 AM Ahmet Altay <altay@google.com
> >     <ma...@google.com>
> >     > <mailto:altay@google.com <ma...@google.com>>> wrote:
> >     >
> >     >     -1 for the same reason as Ismaël. Python version is not
> updated in the
> >     >     release branch [1].
> >     >
> >     >
> >      [1]
> https://github.com/apache/beam/blob/release-2.4.0/sdks/python/apache_beam/version.py#L21
> >     >
> >     >     On Wed, Mar 7, 2018 at 8:39 AM, Jean-Baptiste Onofré <
> jb@nanthrax.net
> >     <ma...@nanthrax.net>
> >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>> wrote:
> >     >
> >     >         No it's not (I'm testing the release right now), I just was
> >     curious and
> >     >         noticed
> >     >         the missing details ;)
> >     >
> >     >         Thanks !
> >     >         Regards
> >     >         JB
> >     >
> >     >         On 03/07/2018 05:17 PM, Robert Bradshaw wrote:
> >     >         > On Wed, Mar 7, 2018 at 12:50 AM Jean-Baptiste Onofré
> >     <jb@nanthrax.net <ma...@nanthrax.net> <mailto:jb@nanthrax.net
> >     <ma...@nanthrax.net>>
> >     >         > <mailto:jb@nanthrax.net <ma...@nanthrax.net>
> >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>> wrote:
> >     >         >
> >     >         >     For the record, the vote e-mail doesn't contain
> actual
> >     MAVEN_VERSION and
> >     >         >     JDK_VERSION used to build.
> >     >         >
> >     >         >
> >     >         > Sorry, it's Apache Maven 3.2.5 with Java version:
> 1.8.0_112.
> >     Hopefully this
> >     >         > isn't a deciding factor :).
> >     >         >
> >     >         >
> >     >         >     Regards
> >     >         >     JB
> >     >         >
> >     >         >     On 03/07/2018 09:44 AM, Robert Bradshaw wrote:
> >     >         >     > Hi everyone,
> >     >         >     >
> >     >         >     > Please review and vote on the release candidate #1
> for the
> >     version 2.4.0,
> >     >         >     > as follows:
> >     >         >     > [ ] +1, Approve the release
> >     >         >     > [ ] -1, Do not approve the release (please provide
> >     specific comments)
> >     >         >     >
> >     >         >     > The complete staging area is available for your
> review,
> >     which includes:
> >     >         >     > * JIRA release notes [1],
> >     >         >     > * the official Apache source release to be
> deployed to
> >     dist.apache.org <http://dist.apache.org> <http://dist.apache.org>
> >     >         >     <http://dist.apache.org> [2],
> >     >         >     > which is signed with the key with fingerprint BDC9
> 89B0
> >     1BD2 A463 6010
> >     >         >     >   A1CA 8F15 5E09 610D 69FB [3],
> >     >         >     > * all artifacts to be deployed to the Maven Central
> >     Repository [4],
> >     >         >     > * source code tag "v2.4.0-RC1" [5],
> >     >         >     > * website pull request listing the release and
> publishing
> >     the API reference
> >     >         >     > manual [6].
> >     >         >     > * Java artifacts were built with Maven
> MAVEN_VERSION and
> >     OpenJDK/Oracle JDK
> >     >         >     > JDK_VERSION.
> >     >         >     > * Python artifacts are deployed along with the
> source
> >     release to the
> >     >         >     > dist.apache.org <http://dist.apache.org>
> >     <http://dist.apache.org>
> >     >         <http://dist.apache.org> [2].
> >     >         >     >
> >     >         >     > The vote will be open for at least 72 hours. It is
> adopted
> >     by majority
> >     >         >     > approval, with at least 3 PMC affirmative votes.
> >     >         >     >
> >     >         >     > Thanks,
> >     >         >     > - Robert
> >     >         >     >
> >     >         >     > [1]
> >     >         >     >
> >     >         >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342682&projectId=12319527
> >     >         >     > [2]
> https://dist.apache.org/repos/dist/dev/beam/2.4.0/
> >     >         >     > [3]
> https://dist.apache.org/repos/dist/dev/beam/KEYS
> >     >         >     > [4]
> >
> https://repository.apache.org/content/repositories/orgapachebeam-1028/
> >     >         >     > [5] https://github.com/apache/beam/tree/v2.4.0-RC1
> >     >         >     > [6] https://github.com/apache/beam-site/pull/398
> >     >         >     >
> >     >         >
> >     >         >     --
> >     >         >     Jean-Baptiste Onofré
> >     >         >     jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
> >     >         <mailto:jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>>
> >     >         >     http://blog.nanthrax.net
> >     >         >     Talend - http://www.talend.com
> >     >         >
> >     >
> >     >         --
> >     >         Jean-Baptiste Onofré
> >     >         jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
> >     >         http://blog.nanthrax.net
> >     >         Talend - http://www.talend.com
> >     >
> >     >
> >
> >     --
> >     Jean-Baptiste Onofré
> >     jbonofre@apache.org <ma...@apache.org>
> >     http://blog.nanthrax.net
> >     Talend - http://www.talend.com
> >
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>

Re: [CANCEL][VOTE] Release 2.4.0, release candidate #1

Posted by Robert Bradshaw <ro...@google.com>.
In combination with https://github.com/apache/beam/pull/4249 . These both
make sense in isolation, but I think the correct fix is to fall back to
bytes comparison for the context of mutation detection rather than throw an
errors.


On Wed, Mar 7, 2018 at 10:54 AM Robert Bradshaw <ro...@google.com> wrote:

> Pretty sure it's
> https://github.com/apache/beam/commit/e3f6d6f1f0c1f9c9ca00ade17c4afedb7d3fef6b#diff-ce2373d2c2282f252c94ed360e729994
> .
>
>
> On Wed, Mar 7, 2018 at 10:41 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
>> Let me run a git bisect to identify the change in cause.
>>
>> Regards
>> JB
>>
>> On 03/07/2018 07:18 PM, Robert Bradshaw wrote:
>> > Done.
>> >
>> > I'm also looking into the direct runner nexmark regression Ismael
>> reported. Does
>> > anyone know how this code has changed since the last release?
>> >
>> > On Wed, Mar 7, 2018 at 10:09 AM Jean-Baptiste Onofré <jb@nanthrax.net
>> > <ma...@nanthrax.net>> wrote:
>> >
>> >     Thanks for the update Robert.
>> >
>> >     Can you please set the thread subject to "[CANCEL][VOTE] Release
>> 2.4.0, release
>> >     candidate #1" for the tracking ?
>> >
>> >     Regards
>> >     JB
>> >
>> >     On 03/07/2018 07:04 PM, Robert Bradshaw wrote:
>> >     > I'm canceling this RC. Hope to get another one out shortly (but
>> if you notice
>> >     > items in the meantime, let me know). This is my first (full)
>> release, so I'm
>> >     > still learning the ropes.
>> >     >
>> >     >
>> >     > On Wed, Mar 7, 2018 at 9:55 AM Jean-Baptiste Onofré <
>> jb@nanthrax.net
>> >     <ma...@nanthrax.net>
>> >     > <mailto:jb@nanthrax.net <ma...@nanthrax.net>>> wrote:
>> >     >
>> >     >     I don't see the staging repo on repository.apache.org
>> >     <http://repository.apache.org>
>> >     >     <http://repository.apache.org> anymore.
>> >     >
>> >     >     Maybe Robert already dropped it due to -1. If it's the case,
>> he should
>> >     have sent
>> >     >     the [CANCEL] e-mail first.
>> >     >
>> >     >     Regards
>> >     >     JB
>> >     >
>> >     >     On 03/07/2018 06:51 PM, Alan Myrvold wrote:
>> >     >     > I don't see anything published
>> >     >     >
>> >     to
>> https://repository.apache.org/content/repositories/orgapachebeam-1028/ ?
>> >     >     >
>> >     >     >
>> >     >     > On Wed, Mar 7, 2018 at 9:26 AM Ahmet Altay <
>> altay@google.com
>> >     <ma...@google.com>
>> >     >     <mailto:altay@google.com <ma...@google.com>>
>> >     >     > <mailto:altay@google.com <ma...@google.com>
>> >     <mailto:altay@google.com <ma...@google.com>>>> wrote:
>> >     >     >
>> >     >     >     -1 for the same reason as Ismaël. Python version is not
>> updated
>> >     in the
>> >     >     >     release branch [1].
>> >     >     >
>> >     >     >
>> >     >
>> >       [1]
>> https://github.com/apache/beam/blob/release-2.4.0/sdks/python/apache_beam/version.py#L21
>> >     >     >
>> >     >     >     On Wed, Mar 7, 2018 at 8:39 AM, Jean-Baptiste Onofré
>> >     <jb@nanthrax.net <ma...@nanthrax.net>
>> >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>
>> >     >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>
>> >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>> wrote:
>> >     >     >
>> >     >     >         No it's not (I'm testing the release right now), I
>> just was
>> >     >     curious and
>> >     >     >         noticed
>> >     >     >         the missing details ;)
>> >     >     >
>> >     >     >         Thanks !
>> >     >     >         Regards
>> >     >     >         JB
>> >     >     >
>> >     >     >         On 03/07/2018 05:17 PM, Robert Bradshaw wrote:
>> >     >     >         > On Wed, Mar 7, 2018 at 12:50 AM Jean-Baptiste
>> Onofré
>> >     >     <jb@nanthrax.net <ma...@nanthrax.net> <mailto:
>> jb@nanthrax.net
>> >     <ma...@nanthrax.net>> <mailto:jb@nanthrax.net <mailto:
>> jb@nanthrax.net>
>> >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>
>> >     >     >         > <mailto:jb@nanthrax.net <ma...@nanthrax.net>
>> >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>
>> >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>
>> >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>>> wrote:
>> >     >     >         >
>> >     >     >         >     For the record, the vote e-mail doesn't
>> contain actual
>> >     >     MAVEN_VERSION and
>> >     >     >         >     JDK_VERSION used to build.
>> >     >     >         >
>> >     >     >         >
>> >     >     >         > Sorry, it's Apache Maven 3.2.5 with Java version:
>> 1.8.0_112.
>> >     >     Hopefully this
>> >     >     >         > isn't a deciding factor :).
>> >     >     >         >
>> >     >     >         >
>> >     >     >         >     Regards
>> >     >     >         >     JB
>> >     >     >         >
>> >     >     >         >     On 03/07/2018 09:44 AM, Robert Bradshaw wrote:
>> >     >     >         >     > Hi everyone,
>> >     >     >         >     >
>> >     >     >         >     > Please review and vote on the release
>> candidate #1
>> >     for the
>> >     >     version 2.4.0,
>> >     >     >         >     > as follows:
>> >     >     >         >     > [ ] +1, Approve the release
>> >     >     >         >     > [ ] -1, Do not approve the release (please
>> provide
>> >     >     specific comments)
>> >     >     >         >     >
>> >     >     >         >     > The complete staging area is available for
>> your review,
>> >     >     which includes:
>> >     >     >         >     > * JIRA release notes [1],
>> >     >     >         >     > * the official Apache source release to be
>> deployed to
>> >     >     dist.apache.org <http://dist.apache.org> <
>> http://dist.apache.org>
>> >     <http://dist.apache.org>
>> >     >     >         >     <http://dist.apache.org> [2],
>> >     >     >         >     > which is signed with the key with
>> fingerprint BDC9 89B0
>> >     >     1BD2 A463 6010
>> >     >     >         >     >   A1CA 8F15 5E09 610D 69FB [3],
>> >     >     >         >     > * all artifacts to be deployed to the Maven
>> Central
>> >     >     Repository [4],
>> >     >     >         >     > * source code tag "v2.4.0-RC1" [5],
>> >     >     >         >     > * website pull request listing the release
>> and
>> >     publishing
>> >     >     the API reference
>> >     >     >         >     > manual [6].
>> >     >     >         >     > * Java artifacts were built with Maven
>> MAVEN_VERSION and
>> >     >     OpenJDK/Oracle JDK
>> >     >     >         >     > JDK_VERSION.
>> >     >     >         >     > * Python artifacts are deployed along with
>> the source
>> >     >     release to the
>> >     >     >         >     > dist.apache.org <http://dist.apache.org>
>> >     <http://dist.apache.org>
>> >     >     <http://dist.apache.org>
>> >     >     >         <http://dist.apache.org> [2].
>> >     >     >         >     >
>> >     >     >         >     > The vote will be open for at least 72
>> hours. It is
>> >     adopted
>> >     >     by majority
>> >     >     >         >     > approval, with at least 3 PMC affirmative
>> votes.
>> >     >     >         >     >
>> >     >     >         >     > Thanks,
>> >     >     >         >     > - Robert
>> >     >     >         >     >
>> >     >     >         >     > [1]
>> >     >     >         >     >
>> >     >     >         >
>> >     >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342682&projectId=12319527
>> >     >     >         >     > [2]
>> https://dist.apache.org/repos/dist/dev/beam/2.4.0/
>> >     >     >         >     > [3]
>> https://dist.apache.org/repos/dist/dev/beam/KEYS
>> >     >     >         >     > [4]
>> >     >
>> https://repository.apache.org/content/repositories/orgapachebeam-1028/
>> >     >     >         >     > [5]
>> https://github.com/apache/beam/tree/v2.4.0-RC1
>> >     >     >         >     > [6]
>> https://github.com/apache/beam-site/pull/398
>> >     >     >         >     >
>> >     >     >         >
>> >     >     >         >     --
>> >     >     >         >     Jean-Baptiste Onofré
>> >     >     >         >     jbonofre@apache.org <mailto:
>> jbonofre@apache.org>
>> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
>> >     >     <mailto:jbonofre@apache.org <ma...@apache.org>
>> >     <mailto:jbonofre@apache.org <ma...@apache.org>>>
>> >     >     >         <mailto:jbonofre@apache.org <mailto:
>> jbonofre@apache.org>
>> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
>> >     >     <mailto:jbonofre@apache.org <ma...@apache.org>
>> >     <mailto:jbonofre@apache.org <ma...@apache.org>>>>
>> >     >     >         >     http://blog.nanthrax.net
>> >     >     >         >     Talend - http://www.talend.com
>> >     >     >         >
>> >     >     >
>> >     >     >         --
>> >     >     >         Jean-Baptiste Onofré
>> >     >     >         jbonofre@apache.org <ma...@apache.org>
>> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
>> >     >     <mailto:jbonofre@apache.org <ma...@apache.org>
>> >     <mailto:jbonofre@apache.org <ma...@apache.org>>>
>> >     >     >         http://blog.nanthrax.net
>> >     >     >         Talend - http://www.talend.com
>> >     >     >
>> >     >     >
>> >     >
>> >     >     --
>> >     >     Jean-Baptiste Onofré
>> >     >     jbonofre@apache.org <ma...@apache.org>
>> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
>> >     >     http://blog.nanthrax.net
>> >     >     Talend - http://www.talend.com
>> >     >
>> >
>> >     --
>> >     Jean-Baptiste Onofré
>> >     jbonofre@apache.org <ma...@apache.org>
>> >     http://blog.nanthrax.net
>> >     Talend - http://www.talend.com
>> >
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>

Re: [CANCEL][VOTE] Release 2.4.0, release candidate #1

Posted by Robert Bradshaw <ro...@google.com>.
Pretty sure it's
https://github.com/apache/beam/commit/e3f6d6f1f0c1f9c9ca00ade17c4afedb7d3fef6b#diff-ce2373d2c2282f252c94ed360e729994
.


On Wed, Mar 7, 2018 at 10:41 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:

> Let me run a git bisect to identify the change in cause.
>
> Regards
> JB
>
> On 03/07/2018 07:18 PM, Robert Bradshaw wrote:
> > Done.
> >
> > I'm also looking into the direct runner nexmark regression Ismael
> reported. Does
> > anyone know how this code has changed since the last release?
> >
> > On Wed, Mar 7, 2018 at 10:09 AM Jean-Baptiste Onofré <jb@nanthrax.net
> > <ma...@nanthrax.net>> wrote:
> >
> >     Thanks for the update Robert.
> >
> >     Can you please set the thread subject to "[CANCEL][VOTE] Release
> 2.4.0, release
> >     candidate #1" for the tracking ?
> >
> >     Regards
> >     JB
> >
> >     On 03/07/2018 07:04 PM, Robert Bradshaw wrote:
> >     > I'm canceling this RC. Hope to get another one out shortly (but if
> you notice
> >     > items in the meantime, let me know). This is my first (full)
> release, so I'm
> >     > still learning the ropes.
> >     >
> >     >
> >     > On Wed, Mar 7, 2018 at 9:55 AM Jean-Baptiste Onofré <
> jb@nanthrax.net
> >     <ma...@nanthrax.net>
> >     > <mailto:jb@nanthrax.net <ma...@nanthrax.net>>> wrote:
> >     >
> >     >     I don't see the staging repo on repository.apache.org
> >     <http://repository.apache.org>
> >     >     <http://repository.apache.org> anymore.
> >     >
> >     >     Maybe Robert already dropped it due to -1. If it's the case,
> he should
> >     have sent
> >     >     the [CANCEL] e-mail first.
> >     >
> >     >     Regards
> >     >     JB
> >     >
> >     >     On 03/07/2018 06:51 PM, Alan Myrvold wrote:
> >     >     > I don't see anything published
> >     >     >
> >     to
> https://repository.apache.org/content/repositories/orgapachebeam-1028/ ?
> >     >     >
> >     >     >
> >     >     > On Wed, Mar 7, 2018 at 9:26 AM Ahmet Altay <altay@google.com
> >     <ma...@google.com>
> >     >     <mailto:altay@google.com <ma...@google.com>>
> >     >     > <mailto:altay@google.com <ma...@google.com>
> >     <mailto:altay@google.com <ma...@google.com>>>> wrote:
> >     >     >
> >     >     >     -1 for the same reason as Ismaël. Python version is not
> updated
> >     in the
> >     >     >     release branch [1].
> >     >     >
> >     >     >
> >     >
> >       [1]
> https://github.com/apache/beam/blob/release-2.4.0/sdks/python/apache_beam/version.py#L21
> >     >     >
> >     >     >     On Wed, Mar 7, 2018 at 8:39 AM, Jean-Baptiste Onofré
> >     <jb@nanthrax.net <ma...@nanthrax.net>
> >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>
> >     >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>
> >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>> wrote:
> >     >     >
> >     >     >         No it's not (I'm testing the release right now), I
> just was
> >     >     curious and
> >     >     >         noticed
> >     >     >         the missing details ;)
> >     >     >
> >     >     >         Thanks !
> >     >     >         Regards
> >     >     >         JB
> >     >     >
> >     >     >         On 03/07/2018 05:17 PM, Robert Bradshaw wrote:
> >     >     >         > On Wed, Mar 7, 2018 at 12:50 AM Jean-Baptiste
> Onofré
> >     >     <jb@nanthrax.net <ma...@nanthrax.net> <mailto:
> jb@nanthrax.net
> >     <ma...@nanthrax.net>> <mailto:jb@nanthrax.net <mailto:
> jb@nanthrax.net>
> >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>
> >     >     >         > <mailto:jb@nanthrax.net <ma...@nanthrax.net>
> >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>
> >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>
> >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>>> wrote:
> >     >     >         >
> >     >     >         >     For the record, the vote e-mail doesn't
> contain actual
> >     >     MAVEN_VERSION and
> >     >     >         >     JDK_VERSION used to build.
> >     >     >         >
> >     >     >         >
> >     >     >         > Sorry, it's Apache Maven 3.2.5 with Java version:
> 1.8.0_112.
> >     >     Hopefully this
> >     >     >         > isn't a deciding factor :).
> >     >     >         >
> >     >     >         >
> >     >     >         >     Regards
> >     >     >         >     JB
> >     >     >         >
> >     >     >         >     On 03/07/2018 09:44 AM, Robert Bradshaw wrote:
> >     >     >         >     > Hi everyone,
> >     >     >         >     >
> >     >     >         >     > Please review and vote on the release
> candidate #1
> >     for the
> >     >     version 2.4.0,
> >     >     >         >     > as follows:
> >     >     >         >     > [ ] +1, Approve the release
> >     >     >         >     > [ ] -1, Do not approve the release (please
> provide
> >     >     specific comments)
> >     >     >         >     >
> >     >     >         >     > The complete staging area is available for
> your review,
> >     >     which includes:
> >     >     >         >     > * JIRA release notes [1],
> >     >     >         >     > * the official Apache source release to be
> deployed to
> >     >     dist.apache.org <http://dist.apache.org> <
> http://dist.apache.org>
> >     <http://dist.apache.org>
> >     >     >         >     <http://dist.apache.org> [2],
> >     >     >         >     > which is signed with the key with
> fingerprint BDC9 89B0
> >     >     1BD2 A463 6010
> >     >     >         >     >   A1CA 8F15 5E09 610D 69FB [3],
> >     >     >         >     > * all artifacts to be deployed to the Maven
> Central
> >     >     Repository [4],
> >     >     >         >     > * source code tag "v2.4.0-RC1" [5],
> >     >     >         >     > * website pull request listing the release
> and
> >     publishing
> >     >     the API reference
> >     >     >         >     > manual [6].
> >     >     >         >     > * Java artifacts were built with Maven
> MAVEN_VERSION and
> >     >     OpenJDK/Oracle JDK
> >     >     >         >     > JDK_VERSION.
> >     >     >         >     > * Python artifacts are deployed along with
> the source
> >     >     release to the
> >     >     >         >     > dist.apache.org <http://dist.apache.org>
> >     <http://dist.apache.org>
> >     >     <http://dist.apache.org>
> >     >     >         <http://dist.apache.org> [2].
> >     >     >         >     >
> >     >     >         >     > The vote will be open for at least 72 hours.
> It is
> >     adopted
> >     >     by majority
> >     >     >         >     > approval, with at least 3 PMC affirmative
> votes.
> >     >     >         >     >
> >     >     >         >     > Thanks,
> >     >     >         >     > - Robert
> >     >     >         >     >
> >     >     >         >     > [1]
> >     >     >         >     >
> >     >     >         >
> >     >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342682&projectId=12319527
> >     >     >         >     > [2]
> https://dist.apache.org/repos/dist/dev/beam/2.4.0/
> >     >     >         >     > [3]
> https://dist.apache.org/repos/dist/dev/beam/KEYS
> >     >     >         >     > [4]
> >     >
> https://repository.apache.org/content/repositories/orgapachebeam-1028/
> >     >     >         >     > [5]
> https://github.com/apache/beam/tree/v2.4.0-RC1
> >     >     >         >     > [6]
> https://github.com/apache/beam-site/pull/398
> >     >     >         >     >
> >     >     >         >
> >     >     >         >     --
> >     >     >         >     Jean-Baptiste Onofré
> >     >     >         >     jbonofre@apache.org <mailto:
> jbonofre@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
> >     >     <mailto:jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>>
> >     >     >         <mailto:jbonofre@apache.org <mailto:
> jbonofre@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
> >     >     <mailto:jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>>>
> >     >     >         >     http://blog.nanthrax.net
> >     >     >         >     Talend - http://www.talend.com
> >     >     >         >
> >     >     >
> >     >     >         --
> >     >     >         Jean-Baptiste Onofré
> >     >     >         jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
> >     >     <mailto:jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>>
> >     >     >         http://blog.nanthrax.net
> >     >     >         Talend - http://www.talend.com
> >     >     >
> >     >     >
> >     >
> >     >     --
> >     >     Jean-Baptiste Onofré
> >     >     jbonofre@apache.org <ma...@apache.org>
> >     <mailto:jbonofre@apache.org <ma...@apache.org>>
> >     >     http://blog.nanthrax.net
> >     >     Talend - http://www.talend.com
> >     >
> >
> >     --
> >     Jean-Baptiste Onofré
> >     jbonofre@apache.org <ma...@apache.org>
> >     http://blog.nanthrax.net
> >     Talend - http://www.talend.com
> >
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>

Re: [CANCEL][VOTE] Release 2.4.0, release candidate #1

Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Let me run a git bisect to identify the change in cause.

Regards
JB

On 03/07/2018 07:18 PM, Robert Bradshaw wrote:
> Done. 
> 
> I'm also looking into the direct runner nexmark regression Ismael reported. Does
> anyone know how this code has changed since the last release? 
> 
> On Wed, Mar 7, 2018 at 10:09 AM Jean-Baptiste Onofré <jb@nanthrax.net
> <ma...@nanthrax.net>> wrote:
> 
>     Thanks for the update Robert.
> 
>     Can you please set the thread subject to "[CANCEL][VOTE] Release 2.4.0, release
>     candidate #1" for the tracking ?
> 
>     Regards
>     JB
> 
>     On 03/07/2018 07:04 PM, Robert Bradshaw wrote:
>     > I'm canceling this RC. Hope to get another one out shortly (but if you notice
>     > items in the meantime, let me know). This is my first (full) release, so I'm
>     > still learning the ropes. 
>     >
>     >
>     > On Wed, Mar 7, 2018 at 9:55 AM Jean-Baptiste Onofré <jb@nanthrax.net
>     <ma...@nanthrax.net>
>     > <mailto:jb@nanthrax.net <ma...@nanthrax.net>>> wrote:
>     >
>     >     I don't see the staging repo on repository.apache.org
>     <http://repository.apache.org>
>     >     <http://repository.apache.org> anymore.
>     >
>     >     Maybe Robert already dropped it due to -1. If it's the case, he should
>     have sent
>     >     the [CANCEL] e-mail first.
>     >
>     >     Regards
>     >     JB
>     >
>     >     On 03/07/2018 06:51 PM, Alan Myrvold wrote:
>     >     > I don't see anything published
>     >     >
>     to https://repository.apache.org/content/repositories/orgapachebeam-1028/ ?
>     >     >
>     >     >
>     >     > On Wed, Mar 7, 2018 at 9:26 AM Ahmet Altay <altay@google.com
>     <ma...@google.com>
>     >     <mailto:altay@google.com <ma...@google.com>>
>     >     > <mailto:altay@google.com <ma...@google.com>
>     <mailto:altay@google.com <ma...@google.com>>>> wrote:
>     >     >
>     >     >     -1 for the same reason as Ismaël. Python version is not updated
>     in the
>     >     >     release branch [1].
>     >     >
>     >     >   
>     >   
>       [1] https://github.com/apache/beam/blob/release-2.4.0/sdks/python/apache_beam/version.py#L21
>     >     >
>     >     >     On Wed, Mar 7, 2018 at 8:39 AM, Jean-Baptiste Onofré
>     <jb@nanthrax.net <ma...@nanthrax.net>
>     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>
>     >     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>
>     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>> wrote:
>     >     >
>     >     >         No it's not (I'm testing the release right now), I just was
>     >     curious and
>     >     >         noticed
>     >     >         the missing details ;)
>     >     >
>     >     >         Thanks !
>     >     >         Regards
>     >     >         JB
>     >     >
>     >     >         On 03/07/2018 05:17 PM, Robert Bradshaw wrote:
>     >     >         > On Wed, Mar 7, 2018 at 12:50 AM Jean-Baptiste Onofré
>     >     <jb@nanthrax.net <ma...@nanthrax.net> <mailto:jb@nanthrax.net
>     <ma...@nanthrax.net>> <mailto:jb@nanthrax.net <ma...@nanthrax.net>
>     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>
>     >     >         > <mailto:jb@nanthrax.net <ma...@nanthrax.net>
>     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>
>     >     <mailto:jb@nanthrax.net <ma...@nanthrax.net>
>     <mailto:jb@nanthrax.net <ma...@nanthrax.net>>>>> wrote:
>     >     >         >
>     >     >         >     For the record, the vote e-mail doesn't contain actual
>     >     MAVEN_VERSION and
>     >     >         >     JDK_VERSION used to build.
>     >     >         >
>     >     >         >
>     >     >         > Sorry, it's Apache Maven 3.2.5 with Java version: 1.8.0_112.
>     >     Hopefully this
>     >     >         > isn't a deciding factor :). 
>     >     >         >  
>     >     >         >
>     >     >         >     Regards
>     >     >         >     JB
>     >     >         >
>     >     >         >     On 03/07/2018 09:44 AM, Robert Bradshaw wrote:
>     >     >         >     > Hi everyone,
>     >     >         >     >
>     >     >         >     > Please review and vote on the release candidate #1
>     for the
>     >     version 2.4.0,
>     >     >         >     > as follows:
>     >     >         >     > [ ] +1, Approve the release
>     >     >         >     > [ ] -1, Do not approve the release (please provide
>     >     specific comments)
>     >     >         >     >
>     >     >         >     > The complete staging area is available for your review,
>     >     which includes:
>     >     >         >     > * JIRA release notes [1],
>     >     >         >     > * the official Apache source release to be deployed to
>     >     dist.apache.org <http://dist.apache.org> <http://dist.apache.org>
>     <http://dist.apache.org>
>     >     >         >     <http://dist.apache.org> [2],
>     >     >         >     > which is signed with the key with fingerprint BDC9 89B0
>     >     1BD2 A463 6010
>     >     >         >     >   A1CA 8F15 5E09 610D 69FB [3],
>     >     >         >     > * all artifacts to be deployed to the Maven Central
>     >     Repository [4],
>     >     >         >     > * source code tag "v2.4.0-RC1" [5],
>     >     >         >     > * website pull request listing the release and
>     publishing
>     >     the API reference
>     >     >         >     > manual [6].
>     >     >         >     > * Java artifacts were built with Maven MAVEN_VERSION and
>     >     OpenJDK/Oracle JDK
>     >     >         >     > JDK_VERSION.
>     >     >         >     > * Python artifacts are deployed along with the source
>     >     release to the
>     >     >         >     > dist.apache.org <http://dist.apache.org>
>     <http://dist.apache.org>
>     >     <http://dist.apache.org>
>     >     >         <http://dist.apache.org> [2].
>     >     >         >     >
>     >     >         >     > The vote will be open for at least 72 hours. It is
>     adopted
>     >     by majority
>     >     >         >     > approval, with at least 3 PMC affirmative votes.
>     >     >         >     >
>     >     >         >     > Thanks,
>     >     >         >     > - Robert
>     >     >         >     >
>     >     >         >     > [1]
>     >     >         >     >
>     >     >         >   
>     >   
>       https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342682&projectId=12319527
>     >     >         >     > [2] https://dist.apache.org/repos/dist/dev/beam/2.4.0/
>     >     >         >     > [3] https://dist.apache.org/repos/dist/dev/beam/KEYS
>     >     >         >     > [4]
>     >     https://repository.apache.org/content/repositories/orgapachebeam-1028/
>     >     >         >     > [5] https://github.com/apache/beam/tree/v2.4.0-RC1
>     >     >         >     > [6] https://github.com/apache/beam-site/pull/398
>     >     >         >     >
>     >     >         >
>     >     >         >     --
>     >     >         >     Jean-Baptiste Onofré
>     >     >         >     jbonofre@apache.org <ma...@apache.org>
>     <mailto:jbonofre@apache.org <ma...@apache.org>>
>     >     <mailto:jbonofre@apache.org <ma...@apache.org>
>     <mailto:jbonofre@apache.org <ma...@apache.org>>>
>     >     >         <mailto:jbonofre@apache.org <ma...@apache.org>
>     <mailto:jbonofre@apache.org <ma...@apache.org>>
>     >     <mailto:jbonofre@apache.org <ma...@apache.org>
>     <mailto:jbonofre@apache.org <ma...@apache.org>>>>
>     >     >         >     http://blog.nanthrax.net
>     >     >         >     Talend - http://www.talend.com
>     >     >         >
>     >     >
>     >     >         --
>     >     >         Jean-Baptiste Onofré
>     >     >         jbonofre@apache.org <ma...@apache.org>
>     <mailto:jbonofre@apache.org <ma...@apache.org>>
>     >     <mailto:jbonofre@apache.org <ma...@apache.org>
>     <mailto:jbonofre@apache.org <ma...@apache.org>>>
>     >     >         http://blog.nanthrax.net
>     >     >         Talend - http://www.talend.com
>     >     >
>     >     >
>     >
>     >     --
>     >     Jean-Baptiste Onofré
>     >     jbonofre@apache.org <ma...@apache.org>
>     <mailto:jbonofre@apache.org <ma...@apache.org>>
>     >     http://blog.nanthrax.net
>     >     Talend - http://www.talend.com
>     >
> 
>     --
>     Jean-Baptiste Onofré
>     jbonofre@apache.org <ma...@apache.org>
>     http://blog.nanthrax.net
>     Talend - http://www.talend.com
> 

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com