You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/29 14:36:32 UTC
[GitHub] [flink] dawidwys opened a new pull request #13844: [FLINK-18363] Add user classloader to context in DeSerializationSchema
dawidwys opened a new pull request #13844:
URL: https://github.com/apache/flink/pull/13844
## What is the purpose of the change
This PR exposes the user code classloader along with the possibility
to register release hooks in the DeserializationSchema and
SerializationSchema.
Additionally it introduces a helper classes for easier creating the
InitializationContexts from a RuntimeContext.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13844: [FLINK-18363] Add user classloader to context in DeSerializationSchema
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13844:
URL: https://github.com/apache/flink/pull/13844#discussion_r514989016
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/serialization/DeserializationSchema.java
##########
@@ -112,5 +114,13 @@ default void deserialize(byte[] message, Collector<T> out) throws IOException {
* @see MetricGroup
*/
MetricGroup getMetricGroup();
+
+ /**
+ * Gets the ClassLoader to load classes that are not in system's classpath, but are part of
+ * the jar file of a user job.
+ *
+ * @see UserCodeClassLoader
Review comment:
```suggestion
* Gets the {@link ClassLoader} to load classes that are not in system's classpath, but are part of
* the jar file of a user job.
*
* @see {@link UserCodeClassLoader}
```
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializationSchema.java
##########
@@ -73,5 +75,13 @@ default void open(InitializationContext context) throws Exception {
* @see MetricGroup
*/
MetricGroup getMetricGroup();
+
+ /**
+ * Gets the ClassLoader to load classes that are not in system's classpath, but are part of
+ * the jar file of a user job.
+ *
+ * @see UserCodeClassLoader
Review comment:
```suggestion
/**
* Gets the {@link ClassLoader} to load classes that are not in system's classpath, but are part of
* the jar file of a user job.
*
* @see {@link UserCodeClassLoader}
```
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/serialization/RuntimeContextInitializationContextAdapters.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.common.serialization;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.util.UserCodeClassLoader;
+
+import java.util.function.Function;
+
+/**
+ * A utility adapters between {@link RuntimeContext}
+ * and {@link DeserializationSchema.InitializationContext}
+ * or {@link SerializationSchema.InitializationContext}.
Review comment:
```suggestion
* A set of adapters between {@link RuntimeContext}
* and {@link DeserializationSchema.InitializationContext}
* or {@link SerializationSchema.InitializationContext}.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13844: [FLINK-18363] Add user classloader to context in DeSerializationSchema
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13844:
URL: https://github.com/apache/flink/pull/13844#issuecomment-718821098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5866ec54cb74e995916e9774487238a40606df08",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5866ec54cb74e995916e9774487238a40606df08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5866ec54cb74e995916e9774487238a40606df08 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13844: [FLINK-18363] Add user classloader to context in DeSerializationSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13844:
URL: https://github.com/apache/flink/pull/13844#issuecomment-718821098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5866ec54cb74e995916e9774487238a40606df08",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8613",
"triggerID" : "5866ec54cb74e995916e9774487238a40606df08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5866ec54cb74e995916e9774487238a40606df08 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8613)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13844: [FLINK-18363] Add user classloader to context in DeSerializationSchema
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13844:
URL: https://github.com/apache/flink/pull/13844#issuecomment-718796673
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5866ec54cb74e995916e9774487238a40606df08 (Thu Oct 29 14:38:32 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13844: [FLINK-18363] Add user classloader to context in DeSerializationSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13844:
URL: https://github.com/apache/flink/pull/13844#issuecomment-718821098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5866ec54cb74e995916e9774487238a40606df08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8613",
"triggerID" : "5866ec54cb74e995916e9774487238a40606df08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5866ec54cb74e995916e9774487238a40606df08 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8613)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org