You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by gp...@apache.org on 2012/07/10 23:50:11 UTC

svn commit: r1359917 - in /myfaces/extensions/validator/trunk: component-support/generic-support/src/main/java/org/apache/myfaces/extensions/validator/generic/renderkit/ core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/

Author: gpetracek
Date: Tue Jul 10 21:50:10 2012
New Revision: 1359917

URL: http://svn.apache.org/viewvc?rev=1359917&view=rev
Log:
EXTVAL-146 reduced string operations - thx to Thomas Andraschko

Modified:
    myfaces/extensions/validator/trunk/component-support/generic-support/src/main/java/org/apache/myfaces/extensions/validator/generic/renderkit/ExtValGenericRendererWrapper.java
    myfaces/extensions/validator/trunk/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererWrapper.java

Modified: myfaces/extensions/validator/trunk/component-support/generic-support/src/main/java/org/apache/myfaces/extensions/validator/generic/renderkit/ExtValGenericRendererWrapper.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/validator/trunk/component-support/generic-support/src/main/java/org/apache/myfaces/extensions/validator/generic/renderkit/ExtValGenericRendererWrapper.java?rev=1359917&r1=1359916&r2=1359917&view=diff
==============================================================================
--- myfaces/extensions/validator/trunk/component-support/generic-support/src/main/java/org/apache/myfaces/extensions/validator/generic/renderkit/ExtValGenericRendererWrapper.java (original)
+++ myfaces/extensions/validator/trunk/component-support/generic-support/src/main/java/org/apache/myfaces/extensions/validator/generic/renderkit/ExtValGenericRendererWrapper.java Tue Jul 10 21:50:10 2012
@@ -27,6 +27,7 @@ import javax.faces.component.UIComponent
 import javax.faces.context.FacesContext;
 import javax.faces.render.Renderer;
 import java.lang.reflect.Method;
+import java.util.logging.Level;
 
 import net.sf.cglib.proxy.MethodInterceptor;
 import net.sf.cglib.proxy.Enhancer;
@@ -89,7 +90,10 @@ public final class ExtValGenericRenderer
         }
         else
         {
-            logger.finest("method " + method.getName() + " called without rendering-interceptors");
+            if (logger.isLoggable(Level.FINEST))
+            {
+                logger.finest("method " + method.getName() + " called without rendering-interceptors");
+            }
 
             try
             {

Modified: myfaces/extensions/validator/trunk/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererWrapper.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/validator/trunk/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererWrapper.java?rev=1359917&r1=1359916&r2=1359917&view=diff
==============================================================================
--- myfaces/extensions/validator/trunk/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererWrapper.java (original)
+++ myfaces/extensions/validator/trunk/core/src/main/java/org/apache/myfaces/extensions/validator/core/renderkit/ExtValRendererWrapper.java Tue Jul 10 21:50:10 2012
@@ -63,7 +63,10 @@ public class ExtValRendererWrapper exten
 
         if(proxyClass == null)
         {
-            logger.finest("no extval renderer proxy configured");
+            if (logger.isLoggable(Level.FINEST))
+            {
+                logger.finest("no extval renderer proxy configured");
+            }
 
             this.wrapped = new ExtValLazyRendererProxy(renderer);
             return;
@@ -82,7 +85,10 @@ public class ExtValRendererWrapper exten
             logger.warning("no extval renderer proxy created for " + renderer.getClass().getName());
         }
 
-        logger.finest("extval renderer wrapper created for " + renderer.getClass().getName());
+        if (logger.isLoggable(Level.FINEST))
+        {
+            logger.finest("extval renderer wrapper created for " + renderer.getClass().getName());
+        }
     }
 
     @Override
@@ -94,7 +100,10 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start beforeDecode of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start beforeDecode of " + rendererInterceptor.getClass().getName());
+                }
 
                 try
                 {
@@ -112,7 +121,10 @@ public class ExtValRendererWrapper exten
                     }
                 }
 
-                logger.finest("beforeDecode of " + rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("beforeDecode of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch(SkipBeforeInterceptorsException e)
@@ -132,11 +144,17 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start afterDecode of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start afterDecode of " + rendererInterceptor.getClass().getName());
+                }
 
                 rendererInterceptor.afterDecode(facesContext, uiComponent, this.wrapped);
 
-                logger.finest("afterDecode of " + rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("afterDecode of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch (SkipAfterInterceptorsException e)
@@ -155,7 +173,10 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start beforeEncodeBegin of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start beforeEncodeBegin of " + rendererInterceptor.getClass().getName());
+                }
 
                 try
                 {
@@ -173,7 +194,10 @@ public class ExtValRendererWrapper exten
                     }
                 }
 
-                logger.finest("beforeEncodeBegin of " + rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("beforeEncodeBegin of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch (SkipBeforeInterceptorsException e)
@@ -193,11 +217,17 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start afterEncodeBegin of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start afterEncodeBegin of " + rendererInterceptor.getClass().getName());
+                }
 
                 rendererInterceptor.afterEncodeBegin(facesContext, uiComponent, this.wrapped);
 
-                logger.finest("afterEncodeBegin of " + rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("afterEncodeBegin of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch (SkipAfterInterceptorsException e)
@@ -216,7 +246,10 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start beforeEncodeChildren of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start beforeEncodeChildren of " + rendererInterceptor.getClass().getName());
+                }
 
                 try
                 {
@@ -234,8 +267,10 @@ public class ExtValRendererWrapper exten
                     }
                 }
 
-                logger.finest("beforeEncodeChildren of " +
-                    rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("beforeEncodeChildren of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch (SkipBeforeInterceptorsException e)
@@ -255,11 +290,17 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start afterEncodeChildren of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start afterEncodeChildren of " + rendererInterceptor.getClass().getName());
+                }
 
                 rendererInterceptor.afterEncodeChildren(facesContext, uiComponent, this.wrapped);
 
-                logger.finest("afterEncodeChildren of " + rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("afterEncodeChildren of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch (SkipAfterInterceptorsException e)
@@ -278,7 +319,10 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start beforeEncodeEnd of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start beforeEncodeEnd of " + rendererInterceptor.getClass().getName());
+                }
 
                 try
                 {
@@ -296,7 +340,10 @@ public class ExtValRendererWrapper exten
                     }
                 }
 
-                logger.finest("beforeEncodeEnd of " + rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("beforeEncodeEnd of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch (SkipBeforeInterceptorsException e)
@@ -316,11 +363,17 @@ public class ExtValRendererWrapper exten
         {
             for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
             {
-                logger.finest("start afterEncodeEnd of " + rendererInterceptor.getClass().getName());
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("start afterEncodeEnd of " + rendererInterceptor.getClass().getName());
+                }
 
                 rendererInterceptor.afterEncodeEnd(facesContext, uiComponent, this.wrapped);
 
-                logger.finest("afterEncodeEnd of " + rendererInterceptor.getClass().getName() + " finished");
+                if (logger.isLoggable(Level.FINEST))
+                {
+                    logger.finest("afterEncodeEnd of " + rendererInterceptor.getClass().getName() + " finished");
+                }
             }
         }
         catch (SkipAfterInterceptorsException e)
@@ -354,7 +407,10 @@ public class ExtValRendererWrapper exten
             {
                 for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
                 {
-                    logger.finest("start beforeGetConvertedValue of " + rendererInterceptor.getClass().getName());
+                    if (logger.isLoggable(Level.FINEST))
+                    {
+                        logger.finest("start beforeGetConvertedValue of " + rendererInterceptor.getClass().getName());
+                    }
 
                     try
                     {
@@ -374,8 +430,11 @@ public class ExtValRendererWrapper exten
                         }
                     }
 
-                    logger.finest("beforeGetConvertedValue of " +
-                        rendererInterceptor.getClass().getName() + " finished");
+                    if (logger.isLoggable(Level.FINEST))
+                    {
+                        logger.finest("beforeGetConvertedValue of " +
+                                rendererInterceptor.getClass().getName() + " finished");
+                    }
                 }
             }
             catch (SkipBeforeInterceptorsException e)
@@ -395,13 +454,19 @@ public class ExtValRendererWrapper exten
             {
                 for(RendererInterceptor rendererInterceptor : extValContext.getRendererInterceptors())
                 {
-                    logger.finest(
-                            "start afterGetConvertedValue of " + rendererInterceptor.getClass().getName());
+                    if (logger.isLoggable(Level.FINEST))
+                    {
+                        logger.finest(
+                                "start afterGetConvertedValue of " + rendererInterceptor.getClass().getName());
+                    }
 
                     rendererInterceptor.afterGetConvertedValue(facesContext, uiComponent, o, this.wrapped);
 
-                    logger.finest(
-                            "afterGetConvertedValue of " + rendererInterceptor.getClass().getName() + " finished");
+                    if (logger.isLoggable(Level.FINEST))
+                    {
+                        logger.finest(
+                                "afterGetConvertedValue of " + rendererInterceptor.getClass().getName() + " finished");
+                    }
                 }
             }
             catch (SkipAfterInterceptorsException e)