[GitHub] [incubator-superset] willbarrett commented on a change in pull request #12226: test: birth names

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #12226:
URL: https://github.com/apache/incubator-superset/pull/12226#discussion_r551619626



##########
File path: tests/celery_tests.py
##########
@@ -208,7 +214,10 @@ def test_run_sync_query_cta_config(setup_sqllab, ctas_method):
     results = run_sql(query.select_sql)
     assert QueryStatus.SUCCESS == results["status"], result
 
+    db.get_engine().execute(f"DROP {ctas_method} {CTAS_SCHEMA_NAME}.{tmp_table_name}")

Review comment:
       Should this be refactored into a shared teardown method?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org