You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Chengwei Yang (JIRA)" <ji...@apache.org> on 2014/06/10 04:07:01 UTC

[jira] [Created] (MESOS-1467) commit msg was changed after run ./support/post-reviews.py

Chengwei Yang created MESOS-1467:
------------------------------------

             Summary: commit msg was changed after run ./support/post-reviews.py
                 Key: MESOS-1467
                 URL: https://issues.apache.org/jira/browse/MESOS-1467
             Project: Mesos
          Issue Type: Bug
          Components: general
    Affects Versions: 0.20.0
         Environment: mesos.git master branch

-bash-4.1$ git --version
git version 1.7.1

            Reporter: Chengwei Yang
            Assignee: Chengwei Yang


post-reviews.py isn't compatible with git version previous to 1.7.2, see below commands.

{code}
-bash-4.1$ git log -1
commit bc1691550d519356e6bda561141baa9f02cdc8ed
Author: Chengwei Yang <ya...@qiyi.com>
Date:   Tue Jun 10 08:59:18 2014 +0800

    test post-review bug
    
    Review: https://reviews.apache.org/r/22406
-bash-4.1$ ./support/post-reviews.py
Running 'rbt post' across all of ...
bc1691550d519356e6bda561141baa9f02cdc8ed - (HEAD, dev) test post-review bug (51 seconds ago)
Creating diff of:

bc1691550d519356e6bda561141baa9f02cdc8ed - (HEAD, dev) test post-review bug
... with parent diff created from:


Press enter to continue or 'Ctrl-C' to skip.

Review request #22409 posted.

https://reviews.apache.org/r/22409/
https://reviews.apache.org/r/22409/diff/
-bash-4.1$ git log -1
commit edada5477db34f162d3f4e21055fa5dfcd83ed11
Author: Chengwei Yang <ya...@qiyi.com>
Date:   Tue Jun 10 08:59:18 2014 +0800

    %B
    Review: https://reviews.apache.org/r/22409
{code}

It can't get the correct review id and create a new one on review board and more problematic is it changed the commit msg to '%B'.

I'm using RHEL 6.3 and the latest git version in repo 1.7.1 and I'd like if we can support it considering to that it's still a widely-used release.



--
This message was sent by Atlassian JIRA
(v6.2#6252)