You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Eugen Paraschiv (JIRA)" <ji...@apache.org> on 2011/04/09 10:44:06 UTC
[jira] [Commented] (DROIDS-56) Change the TaskQueue interface to
java.util.Queue
[ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017831#comment-13017831 ]
Eugen Paraschiv commented on DROIDS-56:
---------------------------------------
I'm aware that this patch is already committed, but I'm running into a serious issue related to it: it has removed the SequentialTaskMaster. The only TaskMaster implementation that is left now is a multithreaded one. First, why would such a major change to TaskMaster implementations be included in a patch related to TaskQueue? Was SequentialTaskMaster incompatible with the concept of using a standard queue? I shouldn't think so, but if it indeed was, can you please explain how?
I called this a major issues because I think this is simply a under the radar removal of a feature clients were relying on, with no reason whatsoever (or at least with no documented one). What is more, that implementation had a very clear purpose and was likely being used (I for one was using it).
Any thoughts on this?
Thanks.
Eugen.
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Mingfai Ma
> Assignee: Bertil Chapuis
> Fix For: 0.0.1, 0.0.2
>
> Attachments: Queue.diff, droids-56-v2.diff, droids-56.diff, taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira