You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yao Xu (Code Review)" <ge...@cloudera.org> on 2019/10/11 09:01:21 UTC
[kudu-CR] [build] Fix a bug for memory gc-itest
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14415
Change subject: [build] Fix a bug for memory_gc-itest
......................................................................
[build] Fix a bug for memory_gc-itest
In CMakeList.txt, we should use KUDU_TCMALLOC_AVAILABLE to determine
whether tcmalloc is enabled instead of TCMALLOC_ENABLED.
Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc
---
M src/kudu/integration-tests/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/14415/1
--
To view, visit http://gerrit.cloudera.org:8080/14415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc
Gerrit-Change-Number: 14415
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
[kudu-CR] [build] Fix a bug for memory gc-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14415 )
Change subject: [build] Fix a bug for memory_gc-itest
......................................................................
[build] Fix a bug for memory_gc-itest
In CMakeList.txt, we should use KUDU_TCMALLOC_AVAILABLE to determine
whether tcmalloc is enabled instead of TCMALLOC_ENABLED.
Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc
Reviewed-on: http://gerrit.cloudera.org:8080/14415
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc
Gerrit-Change-Number: 14415
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [build] Fix a bug for memory gc-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14415 )
Change subject: [build] Fix a bug for memory_gc-itest
......................................................................
Patch Set 1: Code-Review+2
Good catch!
--
To view, visit http://gerrit.cloudera.org:8080/14415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2982af9c7070ffd0f53791d4960c3bccfee4a8cc
Gerrit-Change-Number: 14415
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Fri, 11 Oct 2019 16:48:24 +0000
Gerrit-HasComments: No