You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Steven Dolg (JIRA)" <ji...@apache.org> on 2009/01/26 22:30:00 UTC
[jira] Created: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
------------------------------------------------------------------------
Key: COCOON3-16
URL: https://issues.apache.org/jira/browse/COCOON3-16
Project: Cocoon 3
Issue Type: Bug
Components: cocoon-pipeline
Affects Versions: 3.0.0-alpha-1
Reporter: Steven Dolg
Assignee: Steven Dolg
Fix For: 3.0.0-alpha-2
The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Steven Dolg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Dolg updated COCOON3-16:
-------------------------------
Attachment: consumer.patch
Changed o.a.c.p.c.Consumer to extend o.a.c.p.c.PipelineComponent and added the necessary methods to the implementing classes.
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667459#action_12667459 ]
Grzegorz Kossakowski commented on COCOON3-16:
---------------------------------------------
Steven, I can see some other changes to SaxBuffer. Are they formatting-only?
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667468#action_12667468 ]
Andreas Pieber commented on COCOON3-16:
---------------------------------------
Looks quite nice, but wouldn't it better to inherit the following classes from AbstractPipelineComponent?
o.a.c.p.u.SaxBuffer
o.a.c.p.u.NullXMLConsumer
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Steven Dolg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Dolg closed COCOON3-16.
------------------------------
Resolution: Fixed
Patch applied with minor modifications due to changes that occurred meanwhile.
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Steven Dolg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667465#action_12667465 ]
Steven Dolg commented on COCOON3-16:
------------------------------------
Yes, just checked that - sorry for that.
I guess I'll make a patch without formatting changes...
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Steven Dolg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Dolg updated COCOON3-16:
-------------------------------
Attachment: (was: consumer.patch)
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Steven Dolg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Dolg updated COCOON3-16:
-------------------------------
Attachment: consumer.patch
Patch without formatting changes...
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Steven Dolg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667531#action_12667531 ]
Steven Dolg commented on COCOON3-16:
------------------------------------
Actually I'm not sure about those classes inheriting from AbstractPipelineComponent.
While technically it would make no difference (no additional interfaces implemented nor anything else), this somehow appears strange to me.
Mostly because those are no real pipeline components.
I guess this will need some more changes/improvements, but currently I have no idea what or how...
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON3-16) Fix the class hierarchy of
org.apache.cocoon.pipeline.component.Consumer
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON3-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667598#action_12667598 ]
Carsten Ziegeler commented on COCOON3-16:
-----------------------------------------
We should use the SAXBuffer from cocoon-xml instead and do we really need NullXMLConsumer?
I think we can go without an XMLConsumer completly and just really on ContentHandler. I'll commit with an RT about that in the list.
> Fix the class hierarchy of org.apache.cocoon.pipeline.component.Consumer
> ------------------------------------------------------------------------
>
> Key: COCOON3-16
> URL: https://issues.apache.org/jira/browse/COCOON3-16
> Project: Cocoon 3
> Issue Type: Bug
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-1
> Reporter: Steven Dolg
> Assignee: Steven Dolg
> Fix For: 3.0.0-alpha-2
>
> Attachments: consumer.patch
>
>
> The interface o.a.c.p.c.Consumer does not extend o.a.c.p.c.PipelineComponent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.