You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jo...@apache.org on 2011/05/19 12:40:31 UTC

svn commit: r1124679 - /incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ParserTrainerTool.java

Author: joern
Date: Thu May 19 10:40:31 2011
New Revision: 1124679

URL: http://svn.apache.org/viewvc?rev=1124679&view=rev
Log:
OPENNLP-175 Added validation to Parser trainer cmd line tool

Modified:
    incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ParserTrainerTool.java

Modified: incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ParserTrainerTool.java
URL: http://svn.apache.org/viewvc/incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ParserTrainerTool.java?rev=1124679&r1=1124678&r2=1124679&view=diff
==============================================================================
--- incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ParserTrainerTool.java (original)
+++ incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ParserTrainerTool.java Thu May 19 10:40:31 2011
@@ -112,10 +112,28 @@ public final class ParserTrainerTool imp
       CmdLineUtil.loadTrainingParameters(CmdLineUtil.getParameter("-params", args), true);
     
     if (mlParams != null) {
-      // TODO: Validation is more complex ... 
+      if (!TrainUtil.isValid(mlParams.getSettings("build"))) {
+        System.err.println("Build training parameters are invalid!");
+        throw new TerminateToolException(-1);
+      }
+      
+      if (!TrainUtil.isValid(mlParams.getSettings("check"))) {
+        System.err.println("Check training parameters are invalid!");
+        throw new TerminateToolException(-1);
+      }
+      
+      if (!TrainUtil.isValid(mlParams.getSettings("attach"))) {
+        System.err.println("Attach training parameters are invalid!");
+        throw new TerminateToolException(-1);
+      }
+      
+      if (!TrainUtil.isValid(mlParams.getSettings("tagger"))) {
+        System.err.println("Tagger training parameters are invalid!");
+        throw new TerminateToolException(-1);
+      }
       
-      if (!TrainUtil.isValid(mlParams.getSettings())) {
-        System.err.println("Training parameters file is invalid!");
+      if (!TrainUtil.isValid(mlParams.getSettings("chunker"))) {
+        System.err.println("Chunker training parameters are invalid!");
         throw new TerminateToolException(-1);
       }
     }