You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by ch...@apache.org on 2024/03/24 04:55:12 UTC

(yunikorn-core) branch master updated: [YUNIKORN-2511] Fix flaky TestApplicationHistoryTracking (#827)

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git


The following commit(s) were added to refs/heads/master by this push:
     new b44cc5dd [YUNIKORN-2511] Fix flaky TestApplicationHistoryTracking (#827)
b44cc5dd is described below

commit b44cc5ddd2c4bdb19e7a03cb02aa1eff4a8da69b
Author: targetoee <ta...@gmail.com>
AuthorDate: Sun Mar 24 12:54:39 2024 +0800

    [YUNIKORN-2511] Fix flaky TestApplicationHistoryTracking (#827)
    
    Closes: #827
    
    Signed-off-by: Chia-Ping Tsai <ch...@gmail.com>, Yu-Lin Chen <kh...@gmail.com>
---
 pkg/entrypoint/entrypoint_test.go    | 3 ++-
 pkg/scheduler/tests/recovery_test.go | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/pkg/entrypoint/entrypoint_test.go b/pkg/entrypoint/entrypoint_test.go
index 9d8196f8..ebf39d7f 100644
--- a/pkg/entrypoint/entrypoint_test.go
+++ b/pkg/entrypoint/entrypoint_test.go
@@ -54,7 +54,8 @@ func TestCustomLoggingConfiguration(t *testing.T) {
 	logger, err := config.Build()
 	assert.NilError(t, err, "zap Logger creation failed")
 	log.InitializeLogger(logger, &config)
-	StartAllServices()
+	serviceContext := StartAllServices()
+	defer serviceContext.StopAll()
 	ykManagedLogger := log.Log(log.Core)
 	ykManagedLogger.Info(logMessage)
 	err = ykManagedLogger.Sync()
diff --git a/pkg/scheduler/tests/recovery_test.go b/pkg/scheduler/tests/recovery_test.go
index 772ae3ab..6a7b8d26 100644
--- a/pkg/scheduler/tests/recovery_test.go
+++ b/pkg/scheduler/tests/recovery_test.go
@@ -583,6 +583,7 @@ func TestSchedulerRecoveryWithoutAppInfo(t *testing.T) {
 // test scheduler recovery that only registers nodes and apps
 func TestAppRecovery(t *testing.T) {
 	serviceContext := entrypoint.StartAllServicesWithManualScheduler()
+	defer serviceContext.StopAll()
 	proxy := serviceContext.RMProxy
 
 	BuildInfoMap := make(map[string]string)
@@ -654,6 +655,7 @@ func TestAppRecovery(t *testing.T) {
 // test scheduler recovery that only registers apps
 func TestAppRecoveryAlone(t *testing.T) {
 	serviceContext := entrypoint.StartAllServicesWithManualScheduler()
+	defer serviceContext.StopAll()
 	proxy := serviceContext.RMProxy
 
 	BuildInfoMap := make(map[string]string)


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org