You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ha...@apache.org on 2013/03/31 17:36:48 UTC
svn commit: r1462988 - in /hive/trunk/ql/src:
java/org/apache/hadoop/hive/ql/udf/UDFHour.java
test/queries/clientpositive/udf_hour.q
test/results/clientpositive/udf_hour.q.out
Author: hashutosh
Date: Sun Mar 31 15:36:47 2013
New Revision: 1462988
URL: http://svn.apache.org/r1462988
Log:
HIVE-3850 : hour() function returns 12 hour clock value when using timestamp datatype (Anandha and Franklin via Ashutosh Chauhan)
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java
hive/trunk/ql/src/test/queries/clientpositive/udf_hour.q
hive/trunk/ql/src/test/results/clientpositive/udf_hour.q.out
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java?rev=1462988&r1=1462987&r2=1462988&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java Sun Mar 31 15:36:47 2013
@@ -87,7 +87,7 @@ public class UDFHour extends UDF {
}
calendar.setTime(t.getTimestamp());
- result.set(calendar.get(Calendar.HOUR));
+ result.set(calendar.get(Calendar.HOUR_OF_DAY));
return result;
}
Modified: hive/trunk/ql/src/test/queries/clientpositive/udf_hour.q
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientpositive/udf_hour.q?rev=1462988&r1=1462987&r2=1462988&view=diff
==============================================================================
--- hive/trunk/ql/src/test/queries/clientpositive/udf_hour.q (original)
+++ hive/trunk/ql/src/test/queries/clientpositive/udf_hour.q Sun Mar 31 15:36:47 2013
@@ -7,3 +7,7 @@ FROM src WHERE key = 86;
SELECT hour('2009-08-07 13:14:15'), hour('13:14:15'), hour('2009-08-07')
FROM src WHERE key = 86;
+
+
+SELECT hour(cast('2009-08-07 13:14:15' as timestamp))
+FROM src WHERE key=86;
Modified: hive/trunk/ql/src/test/results/clientpositive/udf_hour.q.out
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/udf_hour.q.out?rev=1462988&r1=1462987&r2=1462988&view=diff
==============================================================================
--- hive/trunk/ql/src/test/results/clientpositive/udf_hour.q.out (original)
+++ hive/trunk/ql/src/test/results/clientpositive/udf_hour.q.out Sun Mar 31 15:36:47 2013
@@ -72,3 +72,14 @@ POSTHOOK: type: QUERY
POSTHOOK: Input: default@src
#### A masked pattern was here ####
13 13 NULL
+PREHOOK: query: SELECT hour(cast('2009-08-07 13:14:15' as timestamp))
+FROM src WHERE key=86
+PREHOOK: type: QUERY
+PREHOOK: Input: default@src
+#### A masked pattern was here ####
+POSTHOOK: query: SELECT hour(cast('2009-08-07 13:14:15' as timestamp))
+FROM src WHERE key=86
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@src
+#### A masked pattern was here ####
+13