You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "924060929 (via GitHub)" <gi...@apache.org> on 2026/01/28 07:18:59 UTC
[PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
924060929 opened a new pull request, #60298:
URL: https://github.com/apache/doris/pull/60298
### What problem does this PR solve?
fix query cache not hit when use sort and one phase aggregation
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 merged PR #60298:
URL: https://github.com/apache/doris/pull/60298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3832609552
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3809582621
<details>
<summary>TPC-H: <b>Total hot run time: 31904 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 81fc88255135202bcd716c9361686132c1c7ea01, data reload: false
------ Round 1 ----------------------------------
q1 17639 5350 5076 5076
q2 2050 318 199 199
q3 10190 1325 771 771
q4 10210 831 307 307
q5 7495 2209 1872 1872
q6 193 182 150 150
q7 880 748 614 614
q8 9267 1376 1204 1204
q9 5116 4755 4801 4755
q10 6785 1968 1564 1564
q11 510 287 276 276
q12 330 367 226 226
q13 17749 4110 3223 3223
q14 233 239 229 229
q15 892 815 821 815
q16 688 681 623 623
q17 642 779 504 504
q18 6743 6449 6638 6449
q19 1253 980 634 634
q20 388 334 231 231
q21 2633 1907 1904 1904
q22 349 309 278 278
Total cold run time: 102235 ms
Total hot run time: 31904 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5338 5306 5305 5305
q2 265 341 251 251
q3 2167 2713 2235 2235
q4 1328 1732 1307 1307
q5 4286 4207 4121 4121
q6 224 179 138 138
q7 1904 2345 1982 1982
q8 2642 2452 2435 2435
q9 7370 7487 7549 7487
q10 2895 3040 2612 2612
q11 519 487 458 458
q12 677 798 660 660
q13 3909 4419 3590 3590
q14 301 342 405 342
q15 916 825 824 824
q16 663 728 681 681
q17 1168 1305 1431 1305
q18 8048 8083 7964 7964
q19 890 853 821 821
q20 2051 2183 1999 1999
q21 4895 4474 4264 4264
q22 588 554 506 506
Total cold run time: 53044 ms
Total hot run time: 51287 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3832609708
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3809453541
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3809650716
<details>
<summary>ClickBench: <b>Total hot run time: 28.21 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 81fc88255135202bcd716c9361686132c1c7ea01, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.04
query3 0.25 0.09 0.08
query4 1.61 0.11 0.11
query5 0.26 0.25 0.25
query6 1.15 0.66 0.67
query7 0.03 0.02 0.02
query8 0.06 0.04 0.04
query9 0.56 0.51 0.49
query10 0.54 0.54 0.54
query11 0.14 0.10 0.09
query12 0.14 0.09 0.11
query13 0.63 0.62 0.62
query14 1.07 1.06 1.06
query15 0.88 0.86 0.86
query16 0.39 0.39 0.38
query17 1.13 1.13 1.10
query18 0.22 0.21 0.21
query19 2.01 1.91 2.06
query20 0.02 0.02 0.02
query21 15.42 0.25 0.13
query22 5.13 0.05 0.05
query23 15.91 0.28 0.11
query24 1.20 0.29 0.79
query25 0.12 0.07 0.08
query26 0.14 0.13 0.13
query27 0.09 0.06 0.04
query28 4.49 1.14 0.96
query29 12.55 3.96 3.18
query30 0.27 0.13 0.12
query31 2.81 0.63 0.40
query32 3.24 0.60 0.49
query33 3.17 3.24 3.26
query34 16.21 5.37 4.71
query35 4.74 4.81 4.80
query36 0.66 0.50 0.49
query37 0.11 0.07 0.07
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.17 0.15
query41 0.09 0.03 0.03
query42 0.05 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 97.98 s
Total hot run time: 28.21 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3810645834
# FE Regression Coverage Report
Increment line coverage ` 100.00% (4/4)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60298_81fc88255135202bcd716c9361686132c1c7ea01_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60298_81fc88255135202bcd716c9361686132c1c7ea01_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3809448385
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](query cache) fix query cache not hit when use sort and one phase aggregation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60298:
URL: https://github.com/apache/doris/pull/60298#issuecomment-3812055526
# FE Regression Coverage Report
Increment line coverage ` 100.00% (4/4)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60298_81fc88255135202bcd716c9361686132c1c7ea01_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60298_81fc88255135202bcd716c9361686132c1c7ea01_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org