[jira] [Commented] (KAFKA-5134) Replace zkClient.getChildren method with zkUtils.getChildren

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017167#comment-16017167 ] 

ASF GitHub Bot commented on KAFKA-5134:
---------------------------------------

GitHub user baluchicken opened a pull request:

    https://github.com/apache/kafka/pull/3097

    KAFKA-5134 Replace zkClient.getChildren method with zkUtils.getChildren

    @ijuma plz review. I also created a version where I didn't refactor the  getPartitionAssignmentForTopics and the getConsumersPerTopic methods, but I thought maybe it is a good idea to do and move the logic (where there is no ZK connection) to the ZkUtils Object.
    About the two new methods, I wanted to make them private and visible only for testing, but because the tests where I use them are not in the same package I couldn't do it. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/baluchicken/kafka-1 KAFKA-5134-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3097
    
----

----


> Replace zkClient.getChildren method with zkUtils.getChildren
> ------------------------------------------------------------
>
>                 Key: KAFKA-5134
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5134
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>            Reporter: Balint Molnar
>            Assignee: Balint Molnar
>
> Refactor related classes to use the zkUtils.getChildren method intead of the zkClient variant.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)