[jira] [Work logged] (HADOOP-17981) Support etag-assisted renames in FileOutputCommitter

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-17981?focusedWorklogId=672602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-672602 ]

ASF GitHub Bot logged work on HADOOP-17981:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Nov/21 10:24
            Start Date: 01/Nov/21 10:24
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on a change in pull request #3597:
URL: https://github.com/apache/hadoop/pull/3597#discussion_r740107063



##########
File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/impl/StoreOperationsThroughFileSystem.java
##########
@@ -0,0 +1,271 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.mapreduce.lib.output.committer.manifest.impl;
+
+import java.io.IOException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.fs.CommonPathCapabilities;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.PathIOException;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.fs.Trash;
+import org.apache.hadoop.fs.impl.ResilientCommitByRename;
+import org.apache.hadoop.mapreduce.lib.output.committer.manifest.files.AbstractManifestData;
+import org.apache.hadoop.mapreduce.lib.output.committer.manifest.files.FileOrDirEntry;
+import org.apache.hadoop.mapreduce.lib.output.committer.manifest.files.TaskManifest;
+import org.apache.hadoop.util.JsonSerialization;
+
+import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.FS_TRASH_INTERVAL_KEY;
+
+/**
+ * Implement task and job operations through the filesystem API.
+ */
+public class StoreOperationsThroughFileSystem extends StoreOperations {

Review comment:
       I screwed up that commit by cherrypicking from the manifest committer branch (which I needed to) -but missed that git adds that as a file. Removed them




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 672602)
    Time Spent: 1h 10m  (was: 1h)

> Support etag-assisted renames in FileOutputCommitter
> ----------------------------------------------------
>
>                 Key: HADOOP-17981
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17981
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs, fs/azure
>    Affects Versions: 3.4.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> To deal with some throttling/retry issues in object stores,
> pass the FileStatus entries retrieved during listing
> into a private interface ResilientCommitByRename which filesystems
> may implement to use extra attributes in the listing (etag, version)
> to constrain and validate the operation.
> Although targeting azure, GCS and others could use. no point in S3A as they shouldn't use this committer.
> # And we are not going to do any changes to FileSystem as there are explicit guarantees of public use and stability.
> I am not going to make that change as the hive thing that will suddenly start expecting it to work forever.
> # I'm not planning to merge this in, as the manifest committer is going to include this and more (MAPREDUCE-7341)
> However, I do need to get this in on a branch, so am doing this work on trunk for dev & test and for others to review



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org