You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/10 08:05:25 UTC
[GitHub] [geode] alb3rtobr opened a new pull request #5231: GEODE-8237: Add note about 'alter region' & cluster conf service
alb3rtobr opened a new pull request #5231:
URL: https://github.com/apache/geode/pull/5231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao commented on a change in pull request #5231: GEODE-8237: Add note about 'alter region' & cluster conf service
Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on a change in pull request #5231:
URL: https://github.com/apache/geode/pull/5231#discussion_r440458433
##########
File path: geode-docs/configuring/cluster_config/gfsh_persist.html.md.erb
##########
@@ -88,6 +88,8 @@ The following `gfsh` commands cause the configuration to be written to all locat
**\*** Note that the `configure pdx` command must be executed *before* starting your data members. This command does not affect any currently running members in the system. Data members (with cluster configuration enabled) that are started after running this command will pick up the new PDX configuration.
+**\*\*** The region this command is applied to must have been created via `gfsh`. If that is not the case, the command will fail saying the region does not exist.
Review comment:
Maybe change it to "the region this command is applied needs to exist in the cluster configuration. If that is not the case...."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao commented on a change in pull request #5231: GEODE-8237: Add note about 'alter region' & cluster conf service
Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on a change in pull request #5231:
URL: https://github.com/apache/geode/pull/5231#discussion_r440458433
##########
File path: geode-docs/configuring/cluster_config/gfsh_persist.html.md.erb
##########
@@ -88,6 +88,8 @@ The following `gfsh` commands cause the configuration to be written to all locat
**\*** Note that the `configure pdx` command must be executed *before* starting your data members. This command does not affect any currently running members in the system. Data members (with cluster configuration enabled) that are started after running this command will pick up the new PDX configuration.
+**\*\*** The region this command is applied to must have been created via `gfsh`. If that is not the case, the command will fail saying the region does not exist.
Review comment:
Maybe change it to "If cluster configuration is enabled, the region this command is applied needs to exist in the cluster configuration. If that is not the case...."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao merged pull request #5231: GEODE-8237: Add note about 'alter region' & cluster conf service
Posted by GitBox <gi...@apache.org>.
jinmeiliao merged pull request #5231:
URL: https://github.com/apache/geode/pull/5231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #5231: GEODE-8237: Add note about 'alter region' & cluster conf service
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #5231:
URL: https://github.com/apache/geode/pull/5231#issuecomment-644908304
> One change, please: change "needs to exist" to "must exist". Thanks.
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #5231: GEODE-8237: Add note about 'alter region' & cluster conf service
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #5231:
URL: https://github.com/apache/geode/pull/5231#issuecomment-644019779
@jinmeiliao this PR adds a note in the documentation about my question you answered in the users lists. Could you take a look? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on a change in pull request #5231: GEODE-8237: Add note about 'alter region' & cluster conf service
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on a change in pull request #5231:
URL: https://github.com/apache/geode/pull/5231#discussion_r440660258
##########
File path: geode-docs/configuring/cluster_config/gfsh_persist.html.md.erb
##########
@@ -88,6 +88,8 @@ The following `gfsh` commands cause the configuration to be written to all locat
**\*** Note that the `configure pdx` command must be executed *before* starting your data members. This command does not affect any currently running members in the system. Data members (with cluster configuration enabled) that are started after running this command will pick up the new PDX configuration.
+**\*\*** The region this command is applied to must have been created via `gfsh`. If that is not the case, the command will fail saying the region does not exist.
Review comment:
done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org