You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by eranwitkon <gi...@git.apache.org> on 2015/10/03 21:52:41 UTC

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

GitHub user eranwitkon opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/334

    zeppelin-333: [WIP] Notebook create delete & clone REST API

    Initial implementation of createNote REST API.
    implementation overlap socket implementation to minimal the effect for socket behavior, later PR can refactor the creation "logic" (create note, add paragraph, set name) to the zengine class and avoid duplication or even better migrate web client to use REST API as well.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eranwitkon/incubator-zeppelin 333

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #334
    
----
commit d5044a1bf9eee6564d6ddff20c9acb2421e269ab
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T19:46:54Z

    initial implementation if createNote REST API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145636200
  
    merged with update flik docs from [this commit](https://github.com/apache/incubator-zeppelin/commit/82ea80dc6a320a7d7e400495afa3cd97f1c523eb)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-147162051
  
    Does someone has more comments on this one, or can we merge it?
    
    
    On Wed, Oct 7, 2015 at 8:09 AM CORNEAU Damien <no...@github.com>
    wrote:
    
    > @eranwitkon <https://github.com/eranwitkon> I can see that :)
    > No problem with API, those are actually useful to me too in some cases.
    > It's just a more global comment about the choice of API calls to include
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146078691>
    > .
    >
    -- 
    Eran | "You don't need eyes to see, you need vision" (Faithless)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

Posted by vmakhaev <gi...@git.apache.org>.
Github user vmakhaev commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145553828
  
    Ok, I see your point. Let's wait for use cases (I do not have any).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146074254
  
    I agree that we shouldn't expose just random API but these are not just any
    utility functions, this is working with notebooks from external
    applications. To me, it can be benificial in few use cases such as one
    described.
    Creating notebooks is zeppelin core functionally and will foster the use of
    Zepplin but exposing interperter is something I wouldn't expose.
    Last but not least, these services are available today as socket API...
    Hope this clearify things, as you see I am a strong believer for API 😃
    Eran
    
    בתאריך יום ד׳, 7 באוק׳ 2015, 05:07 מאת CORNEAU Damien <
    notifications@github.com>:
    
    > Does the Rest API also have the Allow-Origins restrictions?
    >
    > I got nothing against making more REST API calls, however those calls has
    > to have a benefit for Zeppelin. In the last case of @vmakhaev
    > <https://github.com/vmakhaev> it is pretty much out of Zeppelin context.
    >
    > If the context is to have some kind of development kit/Public Rest API
    > (Allow outside process to use the Zeppelin Server), and it's in the
    > RoadMap, then we can work on that. However I don't think random REST API
    > calls without real applications or goal in Zeppelin context should be
    > included in the main source code.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146057741>
    > .
    >
    -- 
    Eran | "You don't need eyes to see, you need vision" (Faithless)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145936956
  
    First, I agree that if it is ok with you we should merge this one and have
    another one for the paragraph requirement.  As I understand,  you are OK
    with the given implementation but want additional API, right?
    As for the Paragraph request,  you are interested in the paragraph body or
    name? What if it doesn't have name?
    
    בתאריך יום ג׳, 6 באוק׳ 2015, 20:25 מאת Vladimir Makhaev <
    notifications@github.com>:
    
    > Sorry, to be late, maybe I should open another issue.
    > I have use case for GET /notebook/:notebookId.
    > We have some pre-defined notebooks, which we display to users in our app.
    > And users are able to select particular paragraph they are interested in.
    > It looks like dropdown with paragraph names and iframe, where selected
    > paragraph is shown. App is associated with notebook by notebookId. So to
    > have list of paragraph we need to get info about particular notebook by
    > it's id.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145934391>
    > .
    >
    -- 
    Eran | "You don't need eyes to see, you need vision" (Faithless)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/334


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by vmakhaev <gi...@git.apache.org>.
Github user vmakhaev commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145934391
  
    Sorry, to be late, maybe I should open another issue.
    I have use case for GET /notebook/:notebookId.
    We have some pre-defined notebooks, which we display to users in our app. And users are able to select particular paragraph they are interested in. It looks like dropdown with paragraph names and iframe, where selected paragraph is shown. App is associated with notebook by notebookId. So to have list of paragraph we need to get info about particular notebook by it's id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-147167127
  
    Looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145816809
  
    For this PR to be merged faster, it should include only your commits, related to the described work.
    Are you sure 0cfa463 is one of them? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145550489
  
    We can technically we can add this but I am intersted of what is the use
    case, zepplin is about interaction which means submitting a query and using
    vis to analyze results. What would you do with get/put?
    One other thing, this require opening the notebook json in the api, I am
    not sure if this is stable and won't change.
    Eran
    
    בתאריך יום ב׳, 5 באוק׳ 2015, 16:25 מאת Vladimir Makhaev <
    notifications@github.com>:
    
    > Looks good. Meets our needs. Looking forward to have it.
    > Only one remark: why would not we add GET /api/notebook/:notebookId for
    > retrieving notebook info and PUT /api/notebook/:notebookId for updating
    > notebook?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145526573>
    > .
    >
    -- 
    Eran | "You don't need eyes to see, you need vision" (Faithless)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145960012
  
    Ok, let's review this PR and merge it. I will open an additional JIRA issue
    for the content of the notebook and we will discuss options in it.
    Eran
    
    בתאריך יום ג׳, 6 באוק׳ 2015, 20:44 מאת Vladimir Makhaev <
    notifications@github.com>:
    
    > Yes, we can merge this and treat my comment as request for additional API.
    > I think in general case we just want to get as much info about particular
    > notebook as we can.
    > In our case we are interested in array of paragraphs and for each
    > paragraph we want to know it's name, id and if it has graph or not. And we
    > only show those which are with graph. Even if it does not have name, it
    > does not matter for us, because we can generate some temporary name to show
    > it in dropdown.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145942562>
    > .
    >
    -- 
    Eran | "You don't need eyes to see, you need vision" (Faithless)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

Posted by eranwitkon <gi...@git.apache.org>.
GitHub user eranwitkon reopened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/334

    zeppelin-333:Notebook create delete & clone REST API

    Initial implementation of createNote REST API.
    implementation overlap socket implementation, to minimal the effect for socket behavior, later PR can refactor the creation "logic" (create note, add paragraph, set name) to the zengine class and avoid duplication or even better migrate web client to use REST API as well.  
    Still need to find a way to broadcast note list to all client same as socket does in 
    ```broadcastNote(note);``` and ```broadcastNoteList();``` 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eranwitkon/incubator-zeppelin 333

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #334
    
----
commit 69b38828f6dc466422498840115b4d6f065bcd57
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T19:46:54Z

    initial implementation if createNote REST API

commit f61bb8c33454483eb07978a1a8d8b1e7f74f090b
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T20:17:34Z

    persist note after create to save new paragraph and new name

commit 310b449f14b9343bb7de633c13f4e848ad6bf2ee
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T22:37:39Z

    Add access to Notebook socket to the NotebookRest API to allow broadcast messages on notebooks changes.

commit d1efbab8578d9c5e062bf5d10fe555fb688e71df
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-05T18:46:12Z

    fix typo

commit d957fa2a84f073d28762a0d316969215976eef9c
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-05T18:47:04Z

    add documentation for notebook create, clone & delete REST API

commit 6a8b569b91f1a356c44007da73c82316cd17f23a
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T21:05:08Z

    initial implementation of Delete notebook REST API

commit 80b885a0ad8092be6053ccf5e8a689524805ff61
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T22:34:23Z

    Add Clone existing note to zengine server

commit defef0588ea2fd2dad2c3a29a7a6104665c886c2
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T22:36:13Z

    refactor clone note to use zengine.notebook.cloneNote and expose brodcast method as public

commit 18f70012b533af6c7467b3026d3051bb630fa2aa
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T22:38:12Z

    Add support for clone Notebook Rest API

commit aa23d3149867f4f2ce576c3011181f7065ff9f88
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T22:39:05Z

    Add cleanup for test of clone REST API

commit 7eb28a09b9fb1b2e6c5f3d2be79949502c593088
Author: eranwitkon <go...@gmail.com>
Date:   2015-10-03T22:51:51Z

    cleanup TODO

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-147633755
  
    Merging it if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145296249
  
    @nberserk please feel free to review and contribute...
    @vmakhaev please review and comment if this meets your request 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/334


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

Posted by vmakhaev <gi...@git.apache.org>.
Github user vmakhaev commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145526573
  
    Looks good. Meets our needs. Looking forward to have it.
    Only one remark: why would not we add GET /api/notebook/:notebookId for retrieving notebook info and PUT /api/notebook/:notebookId for updating notebook?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145817699
  
    The above commit was already merged . I will remove it and rebase on latest.
    Tnx,
    
    בתאריך יום ג׳, 6 באוק׳ 2015, 13:31 מאת Alexander <no...@github.com>:
    
    > For this PR to be merged faster, it should include only your commits,
    > related to the described work.
    > Are you sure 0cfa463
    > <https://github.com/apache/incubator-zeppelin/commit/0cfa463bb91a7e9f8deefb10a25b4c30f6cf8209>
    > is one of them?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145816809>
    > .
    >
    -- 
    Eran | "You don't need eyes to see, you need vision" (Faithless)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146057741
  
    Does the Rest API also have the Allow-Origins restrictions?
    
    I got nothing against making more REST API calls, however those calls has to have a benefit for Zeppelin. In the last case of @vmakhaev it is pretty much out of Zeppelin context.
    
    If the context is to have some kind of development kit/Public Rest API (Allow outside process to use the Zeppelin Server), and it's in the RoadMap, then we can work on that. However I don't think random REST API calls without real applications or goal in Zeppelin context should be included in the main source code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146519919
  
    @corneadoug as for the CORS question, cors filter is added on the server level see [this](https://github.com/apache/incubator-zeppelin/blob/f58c13a650ffa0d8946910bd585f734344ff1f6e/zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java#L222) line so the new API will have it as well.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145629683
  
    This PR includes the following:
    
     - [x] Support for Create, Delete, Clone REST API.
     - [x] implementation of clone on zengine notebook.
     - [x] refactor NotebookServer to use zengine.notebook.clone
     - [x] expose NotebookSocket to NotebookRest to allow broadcast of notebook list changes
     - [x] implement notebook REST API tests
     - [x] update documentation
    
    Ready for review and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333: [WIP] Notebook crea...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145296134
  
    This PR includes the following:
    - [x] Support for Create, Delete, Clone REST API.
    - [x] implementation of clone on zengine notebook.
    - [x] refactor NotebookServer to use zengine.notebook.clone
    - [x] expose NotebookSocket to NotebookRest to allow broadcast of notebook list changes
    - [x] implement notebook REST API tests
    - [ ] update documentation
    
    Please comment as I complete the documentation...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146078691
  
    @eranwitkon I can see that :)
    No problem with API, those are actually useful to me too in some cases.
    It's just a more global comment about the choice of API calls to include


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create dele...

Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145831974
  
    I just re-based on latest master and run test again.
    Ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: zeppelin-333:Notebook create, del...

Posted by vmakhaev <gi...@git.apache.org>.
Github user vmakhaev commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145942562
  
    Yes, we can merge this and treat my comment as request for additional API.
    I think in general case we just want to get as much info about particular notebook as we can.
    In our case we are interested in array of paragraphs and for each paragraph we want to know it's name, id and if it has graph or not. And we only show those which are with graph. Even if it does not have name, it does not matter for us, because we can generate some temporary name to show it in dropdown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---