You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/10 13:29:28 UTC
[GitHub] [netbeans] AlexFalappa opened a new pull request #1941: FlatLaf
Light editor color profile
AlexFalappa opened a new pull request #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941
Initial attempt at an editor color profile that goes well with FlatLaf Light look and feel.
Still contains no syntax specific token colorings
Annotation colorings are those of default NetBeans color profile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1941: FlatLaf Light editor
color profile
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584587781
if you want to adjust you're welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa edited a comment on issue #1941: FlatLaf
Light editor color profile
Posted by GitBox <gi...@apache.org>.
AlexFalappa edited a comment on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584508947
@lkishalmi sure, forgot I had even prepared some 😅 .
Language (e.g. Java) tokens with some highlights (e.g. mark occurrences, guarded sections, folded regions), cursor was on `var` local variable (not captured by screenshot tool):
![token-highlights](https://user-images.githubusercontent.com/1875690/74217810-c74ab480-4ca8-11ea-806f-fc0d6eb4ada0.png)
Markup (e.g. XML) tokens, cursor was on `parent` opening tag:
![token-highlights-markup](https://user-images.githubusercontent.com/1875690/74217823-d467a380-4ca8-11ea-9d58-d2542858d4c7.png)
Here is the standard NetBeans color profile for comparison.
Language tokens:
![netbeans-token-highlights](https://user-images.githubusercontent.com/1875690/74219311-c4ea5980-4cac-11ea-8ac7-03a15db3d101.png)
Markup tokens:
![netbeans-token-highlights-markup](https://user-images.githubusercontent.com/1875690/74219321-cb78d100-4cac-11ea-82d8-c7d49b2704ca.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1941: FlatLaf Light
editor color profile
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584513646
Some syntax highlighting colors were derived from [Nord Theme](https://www.nordtheme.com/) "Aurora" scheme (darkened to better fit a light theme while Nord is a dark theme).
Things to improve:
* warning yellow underline is barely visible, may be make it a shade of light orange?
* not convinced of right margin line, maybe desaturate the blue a bit?
* light blue for keywords and markup elements could be saturated more to make it stand better against white backgorund
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1941: FlatLaf Light editor
color profile
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584178562
Could you attach a teaser screenshot?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #1941: FlatLaf Light editor
color profile
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1941: FlatLaf Light
editor color profile
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584768444
Just tweaked some colors a bit.
Language:
![language](https://user-images.githubusercontent.com/1875690/74264077-59ca7280-4d00-11ea-8b87-5733187f3534.png)
Markup:
![markup](https://user-images.githubusercontent.com/1875690/74264096-60f18080-4d00-11ea-8a68-3cefa5ec22b1.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1941: FlatLaf Light
editor color profile
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584508947
@lkishalmi sure, forgot I had even prepared some 😅 .
Language (e.g. Java) tokens with some highlights (e.g. mark occurrences, guarded sections, folded regions), cursor was on `var` local variable (not captured by screenshot tool):
![token-highlights](https://user-images.githubusercontent.com/1875690/74217810-c74ab480-4ca8-11ea-806f-fc0d6eb4ada0.png)
Markup (e.g. XML) tokens, cursor was on `parent` opening tag:
![token-highlights-markup](https://user-images.githubusercontent.com/1875690/74217823-d467a380-4ca8-11ea-9d58-d2542858d4c7.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] AlexFalappa commented on issue #1941: FlatLaf Light
editor color profile
Posted by GitBox <gi...@apache.org>.
AlexFalappa commented on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584123681
This may be too coarse for NetBeans 11.3.
I leave the choice of whether to include it to the reviewers and release manager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1941: FlatLaf Light editor
color profile
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1941: FlatLaf Light editor color profile
URL: https://github.com/apache/netbeans/pull/1941#issuecomment-584800019
merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists