You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jia Hongchao (Code Review)" <ge...@cloudera.org> on 2019/04/16 03:00:54 UTC

[kudu-CR] remove outdated information from consensus.txt 

Jia Hongchao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13023


Change subject: remove outdated information from consensus.txt
......................................................................

remove outdated information from consensus.txt

It says "For the details of the write-ahead-log (WAL) message
format, see the README file in this directory.", however, there
is no README file there. I think it's better to remove outdated
information.

Change-Id: I4ae6b4dc92477d54f98ac652b35666a2c21a63a2
---
M src/kudu/consensus/consensus.txt
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/13023/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ae6b4dc92477d54f98ac652b35666a2c21a63a2
Gerrit-Change-Number: 13023
Gerrit-PatchSet: 1
Gerrit-Owner: Jia Hongchao <ih...@163.com>

[kudu-CR] remove outdated information from consensus.txt

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13023 )

Change subject: remove outdated information from consensus.txt
......................................................................


Patch Set 1:

I wonder if we should remove this doc entirely. There is a more recent doc in docs/design-docs/consensus.md which I think fully supercedes this one, right?


-- 
To view, visit http://gerrit.cloudera.org:8080/13023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ae6b4dc92477d54f98ac652b35666a2c21a63a2
Gerrit-Change-Number: 13023
Gerrit-PatchSet: 1
Gerrit-Owner: Jia Hongchao <ih...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 22 Apr 2019 21:24:38 +0000
Gerrit-HasComments: No

[kudu-CR] remove outdated information from consensus.txt

Posted by "Jia Hongchao (Code Review)" <ge...@cloudera.org>.
Jia Hongchao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13023 )

Change subject: remove outdated information from consensus.txt
......................................................................


Patch Set 1:

> I wonder if we should remove this doc entirely. There is a more
 > recent doc in docs/design-docs/consensus.md which I think fully
 > supercedes this one, right?

I noticed that file, but it says "Note: This document is out of date."


-- 
To view, visit http://gerrit.cloudera.org:8080/13023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ae6b4dc92477d54f98ac652b35666a2c21a63a2
Gerrit-Change-Number: 13023
Gerrit-PatchSet: 1
Gerrit-Owner: Jia Hongchao <ih...@163.com>
Gerrit-Reviewer: Jia Hongchao <ih...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 24 Apr 2019 01:00:35 +0000
Gerrit-HasComments: No