You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2015/08/14 07:33:43 UTC

[2/2] incubator-kylin git commit: Don’t block cube build if couldn’t parse cube size from MR output

Don’t block cube build if couldn’t parse cube size from MR output

Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/ff4c0771
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/ff4c0771
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/ff4c0771

Branch: refs/heads/0.7-staging
Commit: ff4c0771e1a3af3b2989588276aadaab6c9682c3
Parents: 4c3381b
Author: shaofengshi <sh...@apache.org>
Authored: Fri Aug 14 13:33:19 2015 +0800
Committer: shaofengshi <sh...@apache.org>
Committed: Fri Aug 14 13:33:19 2015 +0800

----------------------------------------------------------------------
 .../kylin/job/cube/UpdateCubeInfoAfterMergeStep.java      | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/ff4c0771/job/src/main/java/org/apache/kylin/job/cube/UpdateCubeInfoAfterMergeStep.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/cube/UpdateCubeInfoAfterMergeStep.java b/job/src/main/java/org/apache/kylin/job/cube/UpdateCubeInfoAfterMergeStep.java
index 8386f8c..284e9c0 100644
--- a/job/src/main/java/org/apache/kylin/job/cube/UpdateCubeInfoAfterMergeStep.java
+++ b/job/src/main/java/org/apache/kylin/job/cube/UpdateCubeInfoAfterMergeStep.java
@@ -34,7 +34,6 @@ import org.apache.kylin.job.execution.AbstractExecutable;
 import org.apache.kylin.job.execution.ExecutableContext;
 import org.apache.kylin.job.execution.ExecuteResult;
 
-import com.google.common.base.Preconditions;
 import com.google.common.collect.Lists;
 
 /**
@@ -62,9 +61,14 @@ public class UpdateCubeInfoAfterMergeStep extends AbstractExecutable {
         if (mergedSegment == null) {
             return new ExecuteResult(ExecuteResult.State.FAILED, "there is no segment with id:" + getSegmentId());
         }
+
+        long cubeSize = 0l;
         String cubeSizeString = executableManager.getOutput(getConvertToHfileStepId()).getExtra().get(ExecutableConstants.HDFS_BYTES_WRITTEN);
-        Preconditions.checkState(StringUtils.isNotEmpty(cubeSizeString), "Can't get cube segment size.");
-        long cubeSize = Long.parseLong(cubeSizeString) / 1024;
+        if (StringUtils.isNotEmpty(cubeSizeString)) {
+            cubeSize = Long.parseLong(cubeSizeString) / 1024;
+        } else {
+            logger.warn("Can not get cube segment size.");
+        }
 
         // collect source statistics
         List<String> mergingSegmentIds = getMergingSegmentIds();