You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "ebarboni (via GitHub)" <gi...@apache.org> on 2023/01/25 16:26:53 UTC
[GitHub] [netbeans-jenkins-lib] ebarboni opened a new pull request, #79: nbpackage attempt
ebarboni opened a new pull request, #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79
-- try not to put on nighlies and archivedartefact the old linux installer
then unpack bin;zip from rao snapshot to be able to use experimental until proper release (22.04 compression fix need to be done in nbpackage)
try to build installer.
@neilcsmith-net put you reviewer so you can merge once rc2 in ok at the pace you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on a diff in pull request #79: nbpackage attempt
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#discussion_r1086977731
##########
vars/asfMainNetBeansBuild.groovy:
##########
@@ -371,13 +355,26 @@ def doParallelClusters(cconfigs) {
def timestamp = sh(returnStdout: true, script: 'date +%y%m%d').trim()
sh "cd distpreparation${versionnedpath}installer && ./installer.sh ${binaryfile} ${version} ${timestamp}"
- sh "cp distpreparation${versionnedpath}installer/dist/bundles/* dist/installers/ "
- publishToNightlies("/netbeans/candidate/installers","distpreparation${versionnedpath}installer/dist/bundles/*","distpreparation${versionnedpath}installer/dist/bundles/")
+ // we archive put to nightlies only exe for window, nbpackage is intended to do the installler
+ sh "cp distpreparation${versionnedpath}installer/dist/bundles/*.exe dist/installers/ "
+ publishToNightlies("/netbeans/candidate/installers","distpreparation${versionnedpath}installer/dist/bundles/*.exe","distpreparation${versionnedpath}installer/dist/bundles/")
sh "rm -rf distpreparation${versionnedpath}installer/dist"
// XXX take too long 18012023 publishToNightlies("/netbeans/candidate/installerspreparation","distpreparation/**/**","distpreparation")
archiveArtifacts 'distpreparation/**'
+
+ sh "mkdir -p nbpackage${versionnedpath}installer"
+ withMaven(maven:tooling.myMaven,jdk:tooling.jdktool,publisherStrategy: 'EXPLICIT',mavenLocalRepo: localRepo,options:[artifactsPublisher(disabled: true)])
+ {
+ // unpack nbpackage snapshot can later
+ sh "mvn org.apache.maven.plugins:maven-dependency-plugin:3.5.0:unpack -DoutputDirectory=nbpackage${versionnedpath}installer -Dartifact=org.apache.netbeans:nbpackage:${nbpackageversion}:bin:zip -Dmaven.repo.local=${env.WORKSPACE}/.repository -DremoteRepositories=apache.snapshots.https::::https://repository.apache.org/snapshots"
+
+ // build installer only deb for testing.
+ sh "nbpackage${versionnedpath}installer/nbpackage-${nbpackageversion}/bin/nbpackage --type linux-deb -Pname=\"Apache NetBeans\" -Pversion=${version} -Purl=\"https://netbeans.apache.org\" -Pdeb.maintainer=\"NetBeans Mailing List <us...@netbeans.apache.org>\" -Pdeb.desktop-filename=\"apache-netbeans-ide-${version}\" -Pdeb.wmclass=\"Apache NetBeans IDE ${version}\" --input dist${versionnedpath}${path}-${rmversion}-bin.zip"
Review Comment:
put in multiline string as it's unreadble.
groovy seems ok in my local jenkins but cannot go far
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on pull request #79: nbpackage attempt
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#issuecomment-1403980874
unpack give me the execute locally so maybe. (but big cliffhanger)
Just commented the publishtonightlies to no interfer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] neilcsmith-net commented on pull request #79: nbpackage attempt
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#issuecomment-1405107035
Well, we've got time to test and revert if necessary before rc3. Although with rpm and deb compression options currently missing, we might not be able to use this for the release anyway, so could test after 17 is out? Your call!
It would be good to remove the whitespace changes. I find it hard to read what's actually changed in the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] neilcsmith-net commented on pull request #79: nbpackage attempt
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#issuecomment-1403977529
OK. Well, it's locked and gone! Does dependency unpack handle the exec permission OK?
In terms of the deb compression, I currently have a `dpkg-deb` script ahead of the original in my path which contains -
```
#!/usr/bin/env sh
echo "WARNING : OVERRIDDEN DPKG_DEB"
exec /usr/bin/dpkg-deb -Zxz "$@"
```
If we could replicate that, we wouldn't need the immediate fix in NBPackage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on pull request #79: nbpackage attempt
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#issuecomment-1403962794
Only test partial on a linux box but not on a spare jenkins . But once rc2 is locked and this go in I can patch and check
only deb as https://ci-builds.apache.org/job/Netbeans/job/testnode/4/console which only show the deb up for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] neilcsmith-net commented on a diff in pull request #79: nbpackage attempt
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#discussion_r1086941096
##########
vars/asfMainNetBeansBuild.groovy:
##########
@@ -371,13 +355,26 @@ def doParallelClusters(cconfigs) {
def timestamp = sh(returnStdout: true, script: 'date +%y%m%d').trim()
sh "cd distpreparation${versionnedpath}installer && ./installer.sh ${binaryfile} ${version} ${timestamp}"
- sh "cp distpreparation${versionnedpath}installer/dist/bundles/* dist/installers/ "
- publishToNightlies("/netbeans/candidate/installers","distpreparation${versionnedpath}installer/dist/bundles/*","distpreparation${versionnedpath}installer/dist/bundles/")
+ // we archive put to nightlies only exe for window, nbpackage is intended to do the installler
+ sh "cp distpreparation${versionnedpath}installer/dist/bundles/*.exe dist/installers/ "
+ publishToNightlies("/netbeans/candidate/installers","distpreparation${versionnedpath}installer/dist/bundles/*.exe","distpreparation${versionnedpath}installer/dist/bundles/")
sh "rm -rf distpreparation${versionnedpath}installer/dist"
// XXX take too long 18012023 publishToNightlies("/netbeans/candidate/installerspreparation","distpreparation/**/**","distpreparation")
archiveArtifacts 'distpreparation/**'
+
+ sh "mkdir -p nbpackage${versionnedpath}installer"
+ withMaven(maven:tooling.myMaven,jdk:tooling.jdktool,publisherStrategy: 'EXPLICIT',mavenLocalRepo: localRepo,options:[artifactsPublisher(disabled: true)])
+ {
+ // unpack nbpackage snapshot can later
+ sh "mvn org.apache.maven.plugins:maven-dependency-plugin:3.5.0:unpack -DoutputDirectory=nbpackage${versionnedpath}installer -Dartifact=org.apache.netbeans:nbpackage:${nbpackageversion}:bin:zip -Dmaven.repo.local=${env.WORKSPACE}/.repository -DremoteRepositories=apache.snapshots.https::::https://repository.apache.org/snapshots"
+
+ // build installer only deb for testing.
+ sh "nbpackage${versionnedpath}installer/nbpackage-${nbpackageversion}/bin/nbpackage --type linux-deb -Pname=\"Apache NetBeans\" -Pversion=${version} -Purl=\"https://netbeans.apache.org\" -Pdeb.maintainer=\"NetBeans Mailing List <us...@netbeans.apache.org>\" -Pdeb.desktop-filename=\"apache-netbeans-ide-${version}\" -Pdeb.wmclass=\"Apache NetBeans IDE ${version}\" --input dist${versionnedpath}${path}-${rmversion}-bin.zip"
Review Comment:
`deb.desktop-filename` and `deb.wmclass` should probably be using `${rmversion}` here. They need to include any suffix in the main window title. `-Pversion` would be good as `${rmversion}` too probably, although using a hyphen breaks the RPM packager currently (hence 17~rc2 on nightlies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni merged pull request #79: nbpackage attempt
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] neilcsmith-net commented on pull request #79: nbpackage attempt
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#issuecomment-1403906755
Thanks. Will take a look shortly. Do you have any sort of test setup for this?
Have handled locally manually and pushed to https://nightlies.apache.org/netbeans/candidate/installers/ for rc2 anyway. Also deleted old installer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on pull request #79: nbpackage attempt
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#issuecomment-1405083157
@neilcsmith-net I fix an issue with locatRepo not defined by testing locally. I had to add withAnt to be able to reproduce upon mvn dep get.
I need to be live to see if it can go after the mvn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-jenkins-lib] ebarboni commented on pull request #79: nbpackage attempt
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #79:
URL: https://github.com/apache/netbeans-jenkins-lib/pull/79#issuecomment-1405119265
well the withAnt addition is the most annoying. Btw need to chek if nbpackage is reached.
will try the deb fix also later.
let's try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists