You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/12 09:12:20 UTC

[GitHub] [cordova-plugin-splashscreen] 21pg opened a new issue #305: unsafe areas behind notches in the screen.

21pg opened a new issue #305:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/305


   # Bug Report
   for iPhone XR devices I am using meta tag: <meta name="viewport" content="user-scalable=no, initial-scale=1, width=device-width, viewport-fit=cover"> but still after first launch i am seeing white space below to notch area. 
   
   ### Version information
   Cordova 10
   Cordova-ios: 6.1.1
   Cordova 10
   
   @globules-io/cordova-plugin-ios-xhr 1.1.0 "Cordova WKWebView File XHR Plugin"
   cordova-plugin-add-swift-support 2.0.2 "AddSwiftSupport"
   cordova-plugin-camera 2.3.1 "Camera"
   cordova-plugin-compat 1.2.0 "Compat"
   cordova-plugin-device 2.0.3 "Device"
   cordova-plugin-dialogs 2.0.2 "Notification"
   cordova-plugin-file 6.0.2 "File"
   cordova-plugin-geolocation 4.0.1 "Geolocation"
   cordova-plugin-globalization 1.0.9 "Globalization"
   cordova-plugin-keyboard 1.2.0 "Keyboard"
   cordova-plugin-splashscreen 6.0.0 "Splashscreen"
   cordova-plugin-whitelist 1.3.4 "Whitelist"
   -->
   
   <preference name="SplashMaintainAspectRatio" value="true" />
       <preference name="FadeSplashScreenDuration" value="300" />
       <preference name="SplashShowOnlyFirstTime" value="false" />
       <preference name="SplashScreen" value="screen" />
       <preference name="SplashScreenDelay" value="3000" />
   
   ![IMG_20201212_140731](https://user-images.githubusercontent.com/64975861/101980019-280b9a80-3c88-11eb-82b0-82f07dd82b8c.jpg)
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [ Y I searched for existing GitHub issues
   - [ YI updated all Cordova tooling to most recent version
   - [ Y I included all the necessary information above
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] sagarchikane commented on issue #305: unsafe areas behind notches in the screen.

Posted by GitBox <gi...@apache.org>.
sagarchikane commented on issue #305:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/305#issuecomment-744501018


   I had tried setting content inset safe values on the HTML body attribute too but that did not work out. So I did some changes within the native WKWebview implementation under `(void)updateSettings:(NSDictionary*)settings` method for the `CDVWebViewEngine.m` file under Cordova library. Following is the batch of code which was added 
   ```
   WKWebView* wkWebView = (WKWebView*)_engineWebView; // already present as part of library code
   wkWebView.scrollView.contentInsetAdjustmentBehavior = UIScrollViewContentInsetAdjustmentNever; // this was added
   ```
   
   This makes sure that the WKContentView takes up complete screen size


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] timbru31 closed issue #305: unsafe areas behind notches in the screen.

Posted by GitBox <gi...@apache.org>.
timbru31 closed issue #305:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/305


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] timbru31 commented on issue #305: unsafe areas behind notches in the screen.

Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #305:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/305#issuecomment-745312434


   Actually, vice versa as the splashscreen plugin has been integrated for iOS


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org