[jira] [Commented] (GEODE-3895) Add Handshake/Message version byte

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227806#comment-16227806 ] 

ASF GitHub Bot commented on GEODE-3895:
---------------------------------------

WireBaron opened a new pull request #1001: GEODE-3895: Add Handshake/Message version byte
URL: https://github.com/apache/geode/pull/1001
 
 
   @galen-pivotal @PivotalSarge @kohlmu-pivotal @bschuchardt 
   
   Signed-off-by: Galen O'Sullivan <go...@pivotal.io>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add Handshake/Message version byte
> ----------------------------------
>
>                 Key: GEODE-3895
>                 URL: https://issues.apache.org/jira/browse/GEODE-3895
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Brian Baynes
>
> Add an extra protocol version byte so that the first two bytes will (initially) be 110 followed by 1. The '1' byte will be increased when the HandshakeRequest or Message changes in such a way that we can't make the handshake backward-compatible.
> Ensure that clients on newer versions will have their connections terminated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)