You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 18:31:54 UTC

[GitHub] [airflow] turbaszek opened a new issue #15994: Use inclusive words in Apache Airflow project

turbaszek opened a new issue #15994:
URL: https://github.com/apache/airflow/issues/15994


   **Description**
   
   Apache Software Foundation is discussing how we can improve inclusiveness of projects and raise awareness of conscious language. Related thread on diversity@a.o:
   https://lists.apache.org/thread.html/r2d8845d9c37ac581046997d980464e8a7b6bffa6400efb0e41013171%40%3Cdiversity.apache.org%3E
   
   **Use case / motivation**
   
   We already have pre-commit check that checks for some word. However, on [CLC (Conscious Language Checker)](https://clcdemo.net/analysis.html?project=airflow.git) Apache Airflow seems to have problems with the following words:
   - he
   - her
   - him
   - his
   - master
   - sanity check
   - slave
   - whitelist (pylintrc)
   
   
   **Are you willing to submit a PR?**
   
   <!--- We accept contributions! -->
   
   **Related Issues**
   
   <!-- Is there currently another issue associated with this? -->
   #12982 https://github.com/apache/airflow/pull/9175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] andriisoldatenko commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
andriisoldatenko commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885123265


   i like NullOperator too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-846155364


   CC @leahecole 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Patil2099 edited a comment on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
Patil2099 edited a comment on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-850405293


   Sorry for the late reply, I have to edit the regex in pre-commit to solve this issue right? @turbaszek.  I have to exclude all the words right? mentioned in  https://github.com/apache/airflow/issues/15994#issue-898308474. I need a little help in that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Patil2099 commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
Patil2099 commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-850405293


   Sorry for the late reply, I have to edit the regex in pre-commit to solve this issue right? @turbaszek.  I have to exclude all the words right? mentioned in  https://github.com/apache/airflow/issues/15994#issue-898308474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854544374


   Yeah. We should likely change DummyOperator but we should deprecate it not remove (and remove it in 3.0). The 'NoOpOperator' or similar could be a good name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854391302


   > Sorry for the late reply, I have to edit the regex in pre-commit to solve this issue right? @turbaszek. I have to exclude all the words right? mentioned in [#15994 (comment)](https://github.com/apache/airflow/issues/15994#issue-898308474). I need a little help in that.
   
   @Patil2099 yes, we should add similar hook to pre-commit-config as this one:
   https://github.com/apache/airflow/blob/476d0f6e3d2059f56532cda36cdc51aa86bafb37/.pre-commit-config.yaml#L333-L341
   The regexp should be like `(?i)(\bmaster\b|\bhe\b|\bshe\b|\bhis\b|\bher\b)` so we match exact word not substrings like `HElp`.
   Also we will need to adjust all occurrences of non-inclusive words. 
   
   
   > Thanks for taking on this! Is there any chance that `DummyOperator` can be renamed to something else, too? I've heard `dummy` may be a non-inclusive word, too.
   
   @ktmud that's interesting suggestion. This would be a breaking change but I think it's worth trying. Any suggestions for a new name? CC @leahecole @kaxil @potiuk 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885846496


   Probably the same as other votes we have had, we can consider all community votes as non-binding but committers & PMC can have binding votes. The Community votes at least give us direction on what our users want :) so the pressure on PMC. But open to suggestions. Looks like `EmptyOperator` is leading on all the polls followed by `NullOperator` and `NoneOperator`. 
   
   All the three mediums have the same voting results: 
   
   ![image](https://user-images.githubusercontent.com/8811558/126830355-ceef5bfd-74f6-4b19-8110-2dc0267da41d.png)
   ![image](https://user-images.githubusercontent.com/8811558/126830369-80df0c27-ded8-4b06-97cd-a4bc24fbe7c4.png)
   ![image](https://user-images.githubusercontent.com/8811558/126830385-5530c504-ca2c-4bfb-ad0b-960ba49b0de0.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854391302


   > Sorry for the late reply, I have to edit the regex in pre-commit to solve this issue right? @turbaszek. I have to exclude all the words right? mentioned in [#15994 (comment)](https://github.com/apache/airflow/issues/15994#issue-898308474). I need a little help in that.
   
   @Patil2099 yes, we should add similar hook to pre-commit-config as this one:
   https://github.com/apache/airflow/blob/476d0f6e3d2059f56532cda36cdc51aa86bafb37/.pre-commit-config.yaml#L333-L341
   The regexp should be like `(?i)(\bmaster\b|\bhe\b|\bshe\b|\bhis\b|\bher\b)` so we match exact word not substrings like `HElp`.
   Also we will need to adjust all occurrences of non-inclusive words. 
   
   
   > Thanks for taking on this! Is there any chance that `DummyOperator` can be renamed to something else, too? I've heard `dummy` may be a non-inclusive word, too.
   
   @ktmud that's interesting suggestion. This would be a breaking change but I think it's worth trying. Any suggestions for a new name? CC @leahecole @kaxil @potiuk 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885171464


   It's really hilarious to see how we have all different opinions and how eager we are to participate in this discussion :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885172145


   BTW. @leahecole  - I also casted different votes, just for the fun of it :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] leahecole commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
leahecole commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-846255023


   Love it. A couple of clarifying questions
   
   - If I'm understanding correctly, the pre commit check is preventing the introduction of new instances of these words, but these are the words we have that were already in? (legacy non-inclusive words, I suppose? 😁 )
   - Is this issue to go through and remove said words, or to introduce more automation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil edited a comment on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-884935507


   I have created polls:
   
   - https://twitter.com/kaxil/status/1418206332662865927?s=20
   - https://www.linkedin.com/posts/kaxil_apacheairflow-activity-6823972796490674176-uaor
   - https://apache-airflow.slack.com/archives/CCR6P6JRL/p1626962523102800
   
   Looks like `EmptyOperator` is getting more votes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-846569504


   @Patil2099 I assigned you to this ticket 👏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854835524


   How about EmptyOperator or TasklessOperator (not sure if this may cause confusion as with Tasks)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-856576000


   +1 for `NullOperator`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-849143842


   > I am not an expert with regular expression. Can you help me with the regular expression? @turbaszek
   
   Sure, what we would like to check? What words?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] sfc-gh-turbaszek removed a comment on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
sfc-gh-turbaszek removed a comment on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885585362


   > It's really hilarious to see how we have all different opinions and how eager we are to participate in this discussion :)
   
   As always in such matters. It reminds me discussion about logo refactor or using asserts in prod code 😅 
   
   Do I correctly assume that we will chose the option that wins all the polls? CC @kaxil 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Patil2099 commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
Patil2099 commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-848766206


   I am not an expert with regular expression. Can you help me with the regular expression?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Patil2099 commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
Patil2099 commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-846559422


   I would love to take this up @turbaszek 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Patil2099 edited a comment on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
Patil2099 edited a comment on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-848766206


   I am not an expert with regular expression. Can you help me with the regular expression? @turbaszek 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal edited a comment on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-859795184


   As for dummy other than `DummyOpeartor` we also have `TriggerRule.DUMMY`
   https://github.com/apache/airflow/blob/5cd0bf733b839951c075c54e808a595ac923c4e8/airflow/utils/trigger_rule.py#L33
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854915745


   Hmmm.. If more people think that `dummy` is not an inclusive word then yes. What do others think, example Twitter Engg https://twitter.com/TwitterEng/status/1278733305190342656/photo/1 does think that "dummy value" term is non-inclusive.
   
   > How about EmptyOperator or TasklessOperator (not sure if this may cause confusion as with Tasks)?
    
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-859795184


   As for dummy other than `DummyOpeartor` we also have `TriggerRule. DUMMY`
   https://github.com/apache/airflow/blob/5cd0bf733b839951c075c54e808a595ac923c4e8/airflow/utils/trigger_rule.py#L33
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] leahecole commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
leahecole commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-858097208


   NullOperator works for me - I have also seen "Placeholder" as a substitution for dummy in our docs if you prefer that 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854893761


   > How about EmptyOperator or TasklessOperator (not sure if this may cause confusion as with Tasks)?
   
   I like `EmptyOperator`, I was wondering about `NodeOperator` because in most of production use cases this operator represent just a node in a DAG.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] sfc-gh-turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
sfc-gh-turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885585362


   > It's really hilarious to see how we have all different opinions and how eager we are to participate in this discussion :)
   
   As always in such matters. It reminds me discussion about logo refactor or using asserts in prod code 😅 
   
   Do I correctly assume that we will chose the option that wins all the polls? CC @kaxil 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-846379074


   > * If I'm understanding correctly, the pre commit check is preventing the introduction of new instances of these words, but these are the words we have that were already in? (legacy non-inclusive words, I suppose? 😁 )
   
   That's one reason. The other one is that #12982 is still opened. Also I some words cannot be removed because are used by 3rd party tools 
   
   > * Is this issue to go through and remove said words, or to introduce more automation?
   
   Both, when we remove the word we should add it to existing rule or create new one similar to this:
   https://github.com/apache/airflow/blob/476d0f6e3d2059f56532cda36cdc51aa86bafb37/.pre-commit-config.yaml#L333-L341
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-884584842


   Opened PR https://github.com/apache/airflow/pull/17144 to handle the Dummy trigger rule deprecation. A question was raised in the PR review if we want NULL trigger rule or something else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] DeOldSax commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
DeOldSax commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-904974941


   How about SentinelOperator? Imho in the domain of algorithms and data structures it's exactly that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854928312


   Yeah.  Dummy is not only non-inclusive but also well a bit dummy :). I like EmptyOperator 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ktmud commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854169789


   Thanks for taking on this! Is there any chance that `DummyOperator` can be renamed to something else, too? I've heard `dummy` may be a non-inclusive word, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-856366575


   In my AIP-39 implementation I called a time table that never schedules (`schedule_interval=None`) a `NullTimeTable` so that's another possibility. It's probably a good idea to keep the naming consistent, so I'll change it if we decide to go with something else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-884748793


   After some comments in #17144 - how about `NoneOperator` ? We are in Python world and Null Operator does not feel right :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] leahecole commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
leahecole commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885113112


   > I have created polls:
   > 
   > * https://twitter.com/kaxil/status/1418206332662865927?s=20
   > * https://www.linkedin.com/posts/kaxil_apacheairflow-activity-6823972796490674176-uaor
   > * https://apache-airflow.slack.com/archives/CCR6P6JRL/p1626962523102800
   > 
   > Looks like `EmptyOperator` is getting more votes
   
   Lol I think I said `NullOperator` here and `EmptyOperator` on Twitter 🤦🏻‍♀️ . And @ashb the `Noperator` makes me laugh and think of the Nopetopus
   ![tenor](https://user-images.githubusercontent.com/6719667/126686437-042943f0-d322-4e4d-9475-24dc3b47da60.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] patchandpray commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
patchandpray commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-884948772


   NullOperator imo fits the bill as it identifies that an operation did occur it just did not create any value but did create some state in the metadata database also it does not conflict with Python's None, if it was named NoneOperator I would assume it would return None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pateash commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
pateash commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-876963816


   +1 for **NullOperator**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-884935507


   I have created polls:
   
   https://twitter.com/kaxil/status/1418206332662865927?s=20
   https://www.linkedin.com/posts/kaxil_apacheairflow-activity-6823972796490674176-uaor
   
   Looks like `EmptyOperator` is getting more votes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-886010279


   I think EmptyOperator is a good choice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ktmud commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-854169789


   Thanks for taking on this! Is there any chance that `DummyOperator` can be renamed to something else, too? I've heard `dummy` may be a non-inclusive word, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-856604563


   +1 works for me
   
   On Tue, Jun 8, 2021 at 10:36 AM Tomek Urbaszek ***@***.***>
   wrote:
   
   > +1 for NullOperator
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/issues/15994#issuecomment-856576000>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAERMIZ76PYYKTBX4XIU3P3TRXJCPANCNFSM45JVCF6A>
   > .
   >
   
   
   -- 
   +48 660 796 129
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-880713045


   > NoOpOperator
   
   What, not "Noperator"? 😉 
   
   +1 for NullOperator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on issue #15994: Use inclusive words in Apache Airflow project

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #15994:
URL: https://github.com/apache/airflow/issues/15994#issuecomment-885586046


   > It's really hilarious to see how we have all different opinions and how eager we are to participate in this discussion :)
   
   It reminds me discussion about logo re-design or asserts in production. But I like the idea of polls 👍 Do I correctly understand that we will pick the winning option @kaxil ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org