[GitHub] [arrow] lidavidm commented on a change in pull request #11831: ARROW-14205: [C++] Add utf8_normalize compute function

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #11831:
URL: https://github.com/apache/arrow/pull/11831#discussion_r760428406



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -407,6 +411,18 @@ struct ARROW_EXPORT WeekOptions : public FunctionOptions {
   bool first_week_is_fully_in_year;
 };
 
+struct ARROW_EXPORT Utf8NormalizeOptions : public FunctionOptions {

Review comment:
       We should add this to function_test.cc: https://github.com/apache/arrow/blob/736a69ee7c0b0b059e08b99783a81067beca99fa/cpp/src/arrow/compute/function_test.cc#L40

##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -30,6 +30,10 @@
 #include "arrow/util/macros.h"
 #include "arrow/util/visibility.h"
 
+#ifdef ARROW_WITH_UTF8PROC
+#include <utf8proc.h>

Review comment:
       Why are we including utf8proc here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org