You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Keta Patel <pa...@us.ibm.com> on 2016/03/08 20:26:40 UTC
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 8, 2016, 7:26 p.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments (updated)
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 10, 2016, 7:01 p.m., Di Li wrote:
> > File Attachment: AMBARI-15310 (patch-4) - AMBARI-15310_Mar09.patch
> > <https://reviews.apache.org/r/44457/#fcomment92>
> >
> > Could you please add unit tests for the methods you added, if possible, to demo the text shortening behavior that you implemented?
Hello Di,
Thank you for this comment. I have added the tests in the patch "AMBARI-15310_Mar10.patch" (patch-5).
The following is the ambari-web test result for the Original trunk:
24564 tests complete (41 seconds)
145 tests pending
The following is the ambari-web test result with the patch (9 new tests).
24573 tests complete (27 seconds)
145 tests pending
Please let me know if further changes are required.
Thanks!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122960
-----------------------------------------------------------
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122960
-----------------------------------------------------------
File Attachment: AMBARI-15310 (patch-4) - AMBARI-15310_Mar09.patch
<https://reviews.apache.org//r/44457/#fcomment91>
Could you please add unit tests for the methods you added, if possible, to demo the text shortening behavior that you implemented?
- Di Li
On March 10, 2016, 12:08 a.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:08 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 15, 2016, 4:07 p.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs (updated)
-----
ambari-web/app/models/host_component.js a325113
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 11b4861
ambari-web/test/models/host_component_test.js 202f5c5
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
AMBARI-15310 (patch-4)
https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
AMBARI-15310 (patch-5)
https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
> On March 14, 2016, 5:47 p.m., Di Li wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you Di!
can you reattach the latest build via the "Update Diff" option? Your AMBARI-15310_Mar10.patch is not up to download via review board.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 14, 2016, 5:47 p.m., Di Li wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you Di!
>
> Di Li wrote:
> can you reattach the latest build via the "Update Diff" option? Your AMBARI-15310_Mar10.patch is not up to download via review board.
Hello Di,
I have attached the latest patch in "Update Diff".
Thank you!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
On March 15, 2016, 4:07 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 4:07 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/models/host_component.js a325113
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 11b4861
> ambari-web/test/models/host_component_test.js 202f5c5
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
> On March 14, 2016, 5:47 p.m., Di Li wrote:
> > Ship It!
Thank you Di!
- Keta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review123464
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On March 11, 2016, 8:08 p.m., Keta Patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:08 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-15310
> https://issues.apache.org/jira/browse/AMBARI-15310
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
> Also, note the indentation of the last button for Clients does not align well with the buttons above it.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less 755dff2
> ambari-web/app/templates/main/host/details/host_component.hbs 60031de
> ambari-web/app/templates/main/host/summary.hbs 17a0b69
>
> Diff: https://reviews.apache.org/r/44457/diff/
>
>
> Testing
> -------
>
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
>
> TESTS:
> No tests are written for these changes as the fix involves updates in the stylesheet.
> However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
>
>
> The following is the result of running ambari-web tests:
>
> 24565 tests complete (28 seconds)
> 145 tests pending
>
>
> File Attachments
> ----------------
>
> AMBARI-15310 (patch-2)
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> AMBARI-15310 (patch-4)
> https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
> AMBARI-15310 (patch-5)
> https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
>
>
> Thanks,
>
> Keta Patel
>
>
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 11, 2016, 8:08 p.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments (updated)
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
AMBARI-15310 (patch-4)
https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
AMBARI-15310 (patch-5)
https://reviews.apache.org/media/uploaded/files/2016/03/11/1f8177ae-91d1-4f48-acf5-3e1dd3ee18bf__AMBARI-15310_Mar10.patch
Thanks,
Keta Patel
Re: Review Request 44457: AMBARI-15310: Host Service Summary Page
does not display long service names well
Posted by Keta Patel <pa...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/
-----------------------------------------------------------
(Updated March 10, 2016, 12:08 a.m.)
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-15310
https://issues.apache.org/jira/browse/AMBARI-15310
Repository: ambari
Description
-------
In Ambari UI, navigate to Hosts and click on the hostname where the service is installed. The summary page displays the list of services installed.
Observe that longer service names does not display well. The refresh icon etc. spills to the next line (see attachment "Original spacing with long service name").
Also, note the indentation of the last button for Clients does not align well with the buttons above it.
Diffs
-----
ambari-web/app/styles/application.less 755dff2
ambari-web/app/templates/main/host/details/host_component.hbs 60031de
ambari-web/app/templates/main/host/summary.hbs 17a0b69
Diff: https://reviews.apache.org/r/44457/diff/
Testing
-------
FIX:
This issue is simialr to AMBARI-11670 where the spacing for each component was fixed in a <div> tag.
The fix here also uses a similar approach where every component is surrounded by a <div> tag and the width is fixed for them so that the appear in their respective positions regardless of the length of service names. I have also adjusted the width of the left <div> component with "span8" instead of "span7" and the right <div> component of the button to "span4" instead of "span5" to better adjust the spacing.
TESTS:
No tests are written for these changes as the fix involves updates in the stylesheet.
However, the changes were tested by zooming in and out and checking if the icons and names were contained in their respective blocks and not overlapping with other <div> blocks.
The following is the result of running ambari-web tests:
24565 tests complete (28 seconds)
145 tests pending
File Attachments (updated)
----------------
AMBARI-15310 (patch-2)
https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
AMBARI-15310 (patch-3)
https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
AMBARI-15310 (patch-4)
https://reviews.apache.org/media/uploaded/files/2016/03/10/22099b48-f563-4c2b-b9fa-2d058e00e053__AMBARI-15310_Mar09.patch
Thanks,
Keta Patel