[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31522:
URL: https://github.com/apache/spark/pull/31522#discussion_r671530371



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala
##########
@@ -221,6 +228,8 @@ object BasicWriteJobStatsTracker {
   private val NUM_OUTPUT_BYTES_KEY = "numOutputBytes"
   private val NUM_OUTPUT_ROWS_KEY = "numOutputRows"
   private val NUM_PARTS_KEY = "numParts"
+  private val DURATION_OF_TASK_COMMIT = "taskCommitDuration"
+  private val DURATION_JOB_COMMIT = "jobCommitDuration"

Review comment:
       Shall we rename these `vals` consistently?
   - `DURATION_OF_TASK_COMMIT` -> `TASK_COMMIT_DURATION`
   - `DURATION_JOB_COMMIT` -> `JOB_COMMIT_DURATION`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org