You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Eric Gillespie <ep...@google.com> on 2008/04/10 22:52:32 UTC
Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include subversion/libsvn_subr
lgo@tigris.org writes:
> +static void
> +gnome_keyring_init()
> +{
> + g_set_application_name("svn");
> +}
Any reason not to say "Subversion"? Especially if this is going
to be shown to a user in a GUI...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include subversion/libsvn_subr
Posted by Lieven Govaerts <sv...@mobsol.be>.
On Fri, Apr 11, 2008 at 1:52 AM, Eric Gillespie <ep...@google.com> wrote:
> Eric Gillespie <ep...@google.com> writes:
>
> > Lieven Govaerts <sv...@mobsol.be> writes:
> >
> > > Eric Gillespie wrote:
> > > > Lieven Govaerts <sv...@mobsol.be> writes:
> > > >
> > > >> I thought we had a constant somewhere with the name of the application
> > > >> in it, but we don't. Fact is, if there's a gnome equivalent for
> > > >> TortoiseSVN, we should be able to show that name in the password popup
> > > >> instead of Subversion.
> > > >
> > > > I don't think so; two separate Subversion frontends should be
> > > > able to share this data.
> > > >
> > > I don't mean storing it under GnomeSVN or whatever, I'm talking about
> > > the title of the Keyring manager popup window which now says something
> > > like 'Application svn wants to save a password' Deny/Allow.
> >
> > I realize that, but it's not "TortoiseSVN" or "NautiluSVN" or
> > whatever that's being configured here.
>
> Actually, upon rereading your change, I retract my position here.
> This stuff isn't keyed on the application *at all*, it's only the
> username and realm string.
Nope, the 'realmstring' is specific to Subversion, it's not only the
realm provided by the server.
In fact, he realmstring is provided by the ra_* layers, and is
implemented the same for ra_neon and ra_serf:
/* <https://svn.collab.net:80> Subversion repository */
realmstring = apr_psprintf(ras->pool, "<%s://%s:%d> %s",
ras->root.scheme, ras->root.host,
ras->root.port, realm);
>
> - I hope that realmstring includes not just the repository realm
> but also the URL :)
Well, it's not the URL of the repository, but from the whole server.
>
> - Subversion > svn
I propose to add an API to set the application name, and use
Subversion as default.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include subversion/libsvn_subr
Posted by Eric Gillespie <ep...@google.com>.
Eric Gillespie <ep...@google.com> writes:
> Lieven Govaerts <sv...@mobsol.be> writes:
>
> > Eric Gillespie wrote:
> > > Lieven Govaerts <sv...@mobsol.be> writes:
> > >
> > >> I thought we had a constant somewhere with the name of the application
> > >> in it, but we don't. Fact is, if there's a gnome equivalent for
> > >> TortoiseSVN, we should be able to show that name in the password popup
> > >> instead of Subversion.
> > >
> > > I don't think so; two separate Subversion frontends should be
> > > able to share this data.
> > >
> > I don't mean storing it under GnomeSVN or whatever, I'm talking about
> > the title of the Keyring manager popup window which now says something
> > like 'Application svn wants to save a password' Deny/Allow.
>
> I realize that, but it's not "TortoiseSVN" or "NautiluSVN" or
> whatever that's being configured here.
Actually, upon rereading your change, I retract my position here.
This stuff isn't keyed on the application *at all*, it's only the
username and realm string. So, if I access an https repository
that requires authn with some hypothetical GNOME-integrated web
browser, that browser will store the password in the keychain.
Later, when I access with hypothetical GNOME Subversion tool, it
doesn't prompt at all, it uses what the browser stored.
So, all I have to say now is:
- I hope that realmstring includes not just the repository realm
but also the URL :)
- Subversion > svn
Thanks.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include subversion/libsvn_subr
Posted by Eric Gillespie <ep...@google.com>.
Lieven Govaerts <sv...@mobsol.be> writes:
> Eric Gillespie wrote:
> > Lieven Govaerts <sv...@mobsol.be> writes:
> >
> >> I thought we had a constant somewhere with the name of the application
> >> in it, but we don't. Fact is, if there's a gnome equivalent for
> >> TortoiseSVN, we should be able to show that name in the password popup
> >> instead of Subversion.
> >
> > I don't think so; two separate Subversion frontends should be
> > able to share this data.
> >
> I don't mean storing it under GnomeSVN or whatever, I'm talking about
> the title of the Keyring manager popup window which now says something
> like 'Application svn wants to save a password' Deny/Allow.
I realize that, but it's not "TortoiseSVN" or "NautiluSVN" or
whatever that's being configured here.
Consider me neutral on the issue of displaying Tortoise
vs. Subversion, but I strongly prefer Subversion to svn.
Thanks for working on this BTW :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include
subversion/libsvn_subr
Posted by Lieven Govaerts <sv...@mobsol.be>.
Eric Gillespie wrote:
> Lieven Govaerts <sv...@mobsol.be> writes:
>
>> I thought we had a constant somewhere with the name of the application
>> in it, but we don't. Fact is, if there's a gnome equivalent for
>> TortoiseSVN, we should be able to show that name in the password popup
>> instead of Subversion.
>
> I don't think so; two separate Subversion frontends should be
> able to share this data.
>
I don't mean storing it under GnomeSVN or whatever, I'm talking about
the title of the Keyring manager popup window which now says something
like 'Application svn wants to save a password' Deny/Allow.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include subversion/libsvn_subr
Posted by Eric Gillespie <ep...@google.com>.
Lieven Govaerts <sv...@mobsol.be> writes:
> I thought we had a constant somewhere with the name of the application
> in it, but we don't. Fact is, if there's a gnome equivalent for
> TortoiseSVN, we should be able to show that name in the password popup
> instead of Subversion.
I don't think so; two separate Subversion frontends should be
able to share this data.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r30485 - in branches/gnome-keyring: . subversion/include
subversion/libsvn_subr
Posted by Lieven Govaerts <sv...@mobsol.be>.
Eric Gillespie wrote:
> lgo@tigris.org writes:
>
>> +static void
>> +gnome_keyring_init()
>> +{
>> + g_set_application_name("svn");
>> +}
>
> Any reason not to say "Subversion"? Especially if this is going
> to be shown to a user in a GUI...
>
I thought we had a constant somewhere with the name of the application
in it, but we don't. Fact is, if there's a gnome equivalent for
TortoiseSVN, we should be able to show that name in the password popup
instead of Subversion.
How do we do that on Mac OS X? We just use 'Subversion'?
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org